You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/18 20:45:06 UTC
Review Request 22749: Allowed launching subprocesses with flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22749/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
See summary. This patch only updated references in libprocess.
Diffs
-----
3rdparty/libprocess/include/process/subprocess.hpp e93608a
3rdparty/libprocess/src/subprocess.cpp 78fa1ec
3rdparty/libprocess/src/tests/subprocess_tests.cpp 1cb1ce3
Diff: https://reviews.apache.org/r/22749/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 22749: Allowed launching subprocesses with flags.
Posted by Jie Yu <yu...@gmail.com>.
> On June 18, 2014, 6:59 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, lines 230-231
> > <https://reviews.apache.org/r/22749/diff/1/?file=612456#file612456line230>
> >
> > The long term solution here is probably to have an array of strings and use a different exec variant. Maybe for the flags case we can assume that 'command' is really 'argv0'? Perhaps suggest this in the TODO so one can circle back.
Added TODO.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22749/#review46109
-----------------------------------------------------------
On June 18, 2014, 6:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22749/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. This patch only updated references in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp e93608a
> 3rdparty/libprocess/src/subprocess.cpp 78fa1ec
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 1cb1ce3
>
> Diff: https://reviews.apache.org/r/22749/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22749: Allowed launching subprocesses with flags.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22749/#review46109
-----------------------------------------------------------
Ship it!
Looks good. I think we might want more overloads at some point that lets us mix and match flags, stdin, stderr, stdout, etc, but we can do that later.
3rdparty/libprocess/src/subprocess.cpp
<https://reviews.apache.org/r/22749/#comment81276>
The long term solution here is probably to have an array of strings and use a different exec variant. Maybe for the flags case we can assume that 'command' is really 'argv0'? Perhaps suggest this in the TODO so one can circle back.
- Benjamin Hindman
On June 18, 2014, 6:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22749/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 6:45 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. This patch only updated references in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp e93608a
> 3rdparty/libprocess/src/subprocess.cpp 78fa1ec
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp 1cb1ce3
>
> Diff: https://reviews.apache.org/r/22749/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>