[GitHub] [flink] jiangjiguang commented on a diff in pull request #20830: [FLINK-29271]Change to byte array from bytebuffer to improve performance and compatible direct byte buffers

[GitBox <gi...@apache.org>]

jiangjiguang commented on code in PR #20830:
URL: https://github.com/apache/flink/pull/20830#discussion_r1002916628


##########
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java:
##########
@@ -265,8 +265,16 @@ void readNextGroup() {
                     while (valueIndex < this.currentCount) {
                         // values are bit packed 8 at a time, so reading bitWidth will always work
                         ByteBuffer buffer = in.slice(bitWidth);
-                        this.packer.unpack8Values(
-                                buffer, buffer.position(), this.currentBuffer, valueIndex);
+                        if (buffer.hasArray()) {
+                            this.packer.unpack8Values(

Review Comment:
   @luoyuxia This BytePacker is only abstract parent class, and unpack8Values will not run this method.
   I have debug code, it run Packer7 class which is code generated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org