[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1317: [CELEBORN-385] Add log rolling log4j configuration.

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1317:
URL: https://github.com/apache/incubator-celeborn/pull/1317#discussion_r1129320785


##########
conf/log4j2.xml.template:
##########
@@ -22,24 +22,20 @@
   -->
 <Configuration status="INFO">
     <Appenders>
-        <Console name="stdout" target="SYSTEM_OUT">
-            <!--
-              ~ In the pattern layout configuration below, we specify an explicit `%ex` conversion
-              ~ pattern for logging Throwables. If this was omitted, then (by default) Log4J would
-              ~ implicitly add an `%xEx` conversion pattern which logs stacktraces with additional
-              ~ class packaging information. That extra information can sometimes add a substantial
-              ~ performance overhead, so we disable it in our default logging config.
-              -->
+        <RollingRandomAccessFile name="rollingBySize" fileName="${env:CELEBORN_LOG_DIR}/celeborn.log" filePattern="${env:CELEBORN_LOG_DIR}/celeborn.log.%d" ignoreExceptions="false" append="true">
             <PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}: %m%n%ex"/>
-        </Console>

Review Comment:
   please reserve the console, it's very useful when manage celeborn using supervisord or in K8s mode. you can add the file separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org