[GitHub] [airflow] msardana94 edited a comment on issue #13679: SQL Syntax errors on startup

[GitBox <gi...@apache.org>]

msardana94 edited a comment on issue #13679:
URL: https://github.com/apache/airflow/issues/13679#issuecomment-762554925


   > @msardana94 are you willing to submit a PR? Please note that the behavior may be different depending on the migration state. see: https://github.com/apache/airflow/blob/master/airflow/migrations/versions/8d48763f6d53_add_unique_constraint_to_conn_id.py
   
   @mik-laj can you elaborate on what you meant here? Isn't it safe to say that as long as sql syntax is accurate, it will check for conn duplicates appropriately?
   
   Also, any thoughts on how to test this issue after adding a bug fix? I can take a look at the db logs after running `airflow upgrade db` but didn't see any unit tests for this in `tests_db.py`. My understanding is [upgrade_db](https://github.com/apache/airflow/blob/ab5f770bfcd8c690cbe4d0825896325aca0beeca/airflow/utils/db.py#L673) will be called when you run the cli command.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org