You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2011/02/11 17:41:38 UTC
svn commit: r1069873 -
/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java
Author: mgrigorov
Date: Fri Feb 11 16:41:38 2011
New Revision: 1069873
URL: http://svn.apache.org/viewvc?rev=1069873&view=rev
Log:
WICKET-3414 Add break after finding Method in AutoComponentResolver invokeSetter
Add a 'break' after finding the match. A little perf improvement.
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java
Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java?rev=1069873&r1=1069872&r2=1069873&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java (original)
+++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/resolver/AutoComponentResolver.java Fri Feb 11 16:41:38 2011
@@ -181,8 +181,9 @@ public final class AutoComponentResolver
// the name might be a Groovy file.
// Note: Spring based components are not supported this way. May be we
// should provide a ComponentFactory like we provide a PageFactory.
- final Class<?> componentClass = container.getSession().getClassResolver().resolveClass(
- classname);
+ final Class<?> componentClass = container.getSession()
+ .getClassResolver()
+ .resolveClass(classname);
final Constructor<?> constructor = componentClass.getConstructor(new Class[] { String.class });
component = (Component)constructor.newInstance(new Object[] { componentId });
@@ -271,6 +272,7 @@ public final class AutoComponentResolver
if (methods[i].getName().equalsIgnoreCase(methodName))
{
method = methods[i];
+ break;
}
}
@@ -293,8 +295,9 @@ public final class AutoComponentResolver
final Class<?> paramClass = parameterClasses[0];
try
{
- final IConverter converter = Application.get().getConverterLocator().getConverter(
- paramClass);
+ final IConverter converter = Application.get()
+ .getConverterLocator()
+ .getConverter(paramClass);
final Object param = converter.convertToObject(value, locale);
if (param == null)
{