You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2011/09/01 08:48:01 UTC
DO NOT REPLY [Bug 51748] New: Apache 2.2.20 Range fix regression.
Negative value handling
https://issues.apache.org/bugzilla/show_bug.cgi?id=51748
Bug #: 51748
Summary: Apache 2.2.20 Range fix regression. Negative value
handling
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: All
AssignedTo: bugs@httpd.apache.org
ReportedBy: lowprio20@gmail.com
Classification: Unclassified
I think the version 2.2.19 behavior is correct.
See RFC 2616 section 14.35.1 "Byte Ranges".
Request and response sample in each versions.
===== version 2.2.20
GET / HTTP/1.1
Host: localhost
Range: bytes=-1
HTTP/1.1 206 Partial Content
Server: Apache/2.2.20 (Unix)
Accept-Ranges: bytes
Content-Length: 2
Content-Range: bytes 0-1/10240
Content-Type: text/html
===== version 2.2.19
GET / HTTP/1.1
Host: localhost
Range: bytes=-1
HTTP/1.1 206 Partial Content
Server: Apache/2.2.19 (Unix)
Accept-Ranges: bytes
Content-Length: 1
Content-Range: bytes 10239-10239/10240
Content-Type: text/html
=====
Fix patch for version 2.2.20 release.
=====
diff -Nur httpd-2.2.20-orig/modules/http/byterange_filter.c
httpd-2.2.20/modules/http/byterange_filter.c
--- httpd-2.2.20-orig/modules/http/byterange_filter.c 2011-08-30
00:59:39.000000000 +0900
+++ httpd-2.2.20/modules/http/byterange_filter.c 2011-09-01
15:05:44.000000000 +0900
@@ -501,7 +501,7 @@
break;
}
- if (dash == range) {
+ if (dash == cur) {
/* In the form "-5" */
if (apr_strtoff(&number, dash+1, &errp, 10) || *errp) {
break;
=====
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 51748] Apache 2.2.20 Range fix regression.
Negative value handling
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51748
--- Comment #4 from Tomas Hoger <th...@redhat.com> 2011-11-14 13:04:18 UTC ---
Regarding comment #2, I wonder if it's been overlooked, or whatever the
behaviour (invalid vs. unsatisfiable) is for the meaningless case is considered
fine. Should I do separate bug for it? Thanks!
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 51748] Apache 2.2.20 Range fix regression.
Negative value handling
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51748
Ruediger Pluem <rp...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
--- Comment #1 from Ruediger Pluem <rp...@apache.org> 2011-09-01 10:26:32 UTC ---
You are correct. Fixed in trunk as r1163985.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 51748] Apache 2.2.20 Range fix regression. Negative value
handling
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51748
--- Comment #5 from Jackie Rosen <ja...@hushmail.com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Page where seen: http://volichat.com/adult-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 51748] Apache 2.2.20 Range fix regression.
Negative value handling
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51748
Tomas Hoger <th...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |thoger@redhat.com
--- Comment #2 from Tomas Hoger <th...@redhat.com> 2011-09-13 12:52:07 UTC ---
There is one special case here: -0
RFC does not define that case as syntactically invalid. My reading is that
it's considered valid but unsatisfiable (If a syntactically valid
byte-range-set includes ... at least one suffix-byte-range-spec with a non-zero
suffix-length, then the byte-range-set is satisfiable.).
The latest httpd behaviour is to handle that as invalid, hence ignore Range
header and return 200. That's quite reasonable, given that -0 is not any
better than invalid 10-9. Just noting here so it can be decided if it should
stay as is or be changed to be more rfc-compliant. Required change seems
trivial (allowing number >= 0).
And maybe I'm just reading the RFC wrong.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 51748] Apache 2.2.20 Range fix regression.
Negative value handling
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51748
Stefan Fritsch <sf...@sfritsch.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Stefan Fritsch <sf...@sfritsch.de> 2011-09-17 15:22:17 UTC ---
Fixed in 2.2.21
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org