You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/10/30 07:19:49 UTC
[GitHub] codecov-io commented on issue #476: SCB-994 SC can not read the
context when client using grpc api
codecov-io commented on issue #476: SCB-994 SC can not read the context when client using grpc api
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/476#issuecomment-434196227
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=h1) Report
> Merging [#476](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f67d612893a03e5ea9e206c625491bb7f02c58a7?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `90.9%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #476 +/- ##
=========================================
+ Coverage 60.39% 60.4% +0.01%
=========================================
Files 156 157 +1
Lines 13379 13388 +9
=========================================
+ Hits 8080 8087 +7
- Misses 4722 4723 +1
- Partials 577 578 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/util/context\_grpc.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-cGtnL3V0aWwvY29udGV4dF9ncnBjLmdv) | `100% <100%> (ø)` | |
| [pkg/util/context.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-cGtnL3V0aWwvY29udGV4dC5nbw==) | `78.4% <75%> (-0.67%)` | :arrow_down: |
| [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: |
| [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.78% <0%> (-0.16%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: |
| [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `48.43% <0%> (+1.56%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=footer). Last update [f67d612...9766d1c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/476?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services