You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/05 12:53:05 UTC
[GitHub] [flink] zentol commented on a change in pull request #8545:
[FLINK-12520] Support to provide fully-qualified domain host name in
TaskManagerMetricGroup
zentol commented on a change in pull request #8545: [FLINK-12520] Support to provide fully-qualified domain host name in TaskManagerMetricGroup
URL: https://github.com/apache/flink/pull/8545#discussion_r300671122
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
##########
@@ -185,6 +185,14 @@
"faster updating metrics. Increase this value if the metric fetcher causes too much load. Setting this value to 0 " +
"disables the metric fetching completely.");
+ /**
+ * Whether the host name in task manager metrics should be fully qualified domain name.
+ */
+ public static final ConfigOption<Boolean> METRIC_FULL_HOST_NAME =
+ key("metrics.tm.full-hostname")
Review comment:
This should pretty easy to solve, just pass in both the host and host_fqdn into the TaskManagerMetricGroup.
I'm fine with calling it `<host_fqdn>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services