You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2018/11/15 01:14:35 UTC

[incubator-pinot] branch hotfix_time_conversion created (now 3989cfd)

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a change to branch hotfix_time_conversion
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.


      at 3989cfd  Hotfix for realtime time conversion when incoming and outgoing time column name are the same

This branch includes the following new commits:

     new 3989cfd  Hotfix for realtime time conversion when incoming and outgoing time column name are the same

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[incubator-pinot] 01/01: Hotfix for realtime time conversion when incoming and outgoing time column name are the same

Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch hotfix_time_conversion
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit 3989cfdbd892f55da8c20ead9619e32dd15b7ff2
Author: Xiaotian (Jackie) Jiang <xa...@linkedin.com>
AuthorDate: Wed Nov 14 17:14:07 2018 -0800

    Hotfix for realtime time conversion when incoming and outgoing time column name are the same
---
 .../pinot/core/data/recordtransformer/TimeTransformer.java         | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/pinot-core/src/main/java/com/linkedin/pinot/core/data/recordtransformer/TimeTransformer.java b/pinot-core/src/main/java/com/linkedin/pinot/core/data/recordtransformer/TimeTransformer.java
index 2ee8e00..059a739 100644
--- a/pinot-core/src/main/java/com/linkedin/pinot/core/data/recordtransformer/TimeTransformer.java
+++ b/pinot-core/src/main/java/com/linkedin/pinot/core/data/recordtransformer/TimeTransformer.java
@@ -55,10 +55,9 @@ public class TimeTransformer implements RecordTransformer {
     if (_timeConverter == null) {
       return record;
     }
-    // Skip transformation if outgoing value already exist
-    // NOTE: outgoing value might already exist for OFFLINE data
-    if (record.getValue(_outgoingTimeColumn) == null) {
-      record.putField(_outgoingTimeColumn, _timeConverter.convert(record.getValue(_incomingTimeColumn)));
+    Object incomingValue = record.getValue(_incomingTimeColumn);
+    if (incomingValue != null) {
+      record.putField(_outgoingTimeColumn, _timeConverter.convert(incomingValue));
     }
     return record;
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org