[GitHub] [arrow] lidavidm commented on pull request #13101: ARROW-16507: [CI][C++] Use system gtest with mamba/conda

[GitBox <gi...@apache.org>]

lidavidm commented on PR #13101:
URL: https://github.com/apache/arrow/pull/13101#issuecomment-1127494197

   > I think that a real fix for this is stopping `class ARROW_FLIGHT_EXPORT arrow::flight::FlightTest : public testing::Test` in https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/test_definitions.h that is introduced by #12499/[ARROW-15707](https://issues.apache.org/jira/browse/ARROW-15707). (Cc: @lidavidm)
   > If we implement shared tests by header only library, macro or something instead of shared library, we can use static library version of GoogleTest for `arrow_flight_testing.dll`.
   
   Hmm, part of the motivation was to try to save some compile time instead of having to include the full definition of all tests. But if it's causing problems I can move it into a header only library instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org