You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/13 09:56:18 UTC
[GitHub] [netbeans] jlahoda opened a new pull request #3598: Handle classfiles with two new versions.
jlahoda opened a new pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598
javac normally refuses to load classfiles that are too new (unlike old nb-javac). Classfile versions change fairly frequently, but javac can often load the newer classfiles anyway. So let's try to load them, as did nb-javac. (It will be a bit slower to read the too-new classfile, but I think that is mostly fine.)
Based on a report from here:
https://lists.apache.org/thread/gtv4nnhvjtzqrk8zmsojj70blw0n18yv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3598: Handle classfiles with two new versions.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1038454933
awesome :)
nitpick: typo in commit msg and PR title. two -> too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3598: Handle classfiles with two new versions.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1038454933
awesome :)
nitpick: typo in commit msg and PR title. two -> too
curious, what will `org.netbeans.api.java.source.CompilationInfo#getSourceVersion()` return after this? The modified version or the version set for the project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1065932239
This was proposed to NB13, anyone objecting merging it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1040197708
Well, I've no more say than anyone else what goes in NB13! However, I do have reservations about dropping this in so late. I'm also curious what the implications are with things like Compile on Save? Hard fail with workaround in NB13, and aiming to look at a better experience for this in NB14 seems a good move to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3598: Handle classfiles with two new versions.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1038454933
awesome :)
nitpick: typo in commit msg and PR title. two -> too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3598: Handle classfiles with two new versions.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1038454933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1040197708
Well, I've no more say than anyone else what goes in NB13! However, I do have reservations about dropping this in so late. I'm also curious what the implications are with things like Compile on Save? Hard fail with workaround in NB13, and aiming to look at a better experience for this in NB14 seems a good move to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1074328666
Got approved, tests seems to be happy. I'm merging this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1039053568
> There will be another rc for NB 13 on Tuesday. From a certain perspective this could be seen as a bug fix. Might be worth to rebase to delivery.
I can rebase, I think, but I'll leave it up to @neilcsmith-net is he would be interested to include this in NB 13. To me, seems it could wait for the next version, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #3598: Handle classfiles with too new versions.
Posted by GitBox <gi...@apache.org>.
jlahoda commented on pull request #3598:
URL: https://github.com/apache/netbeans/pull/3598#issuecomment-1039053806
(Thanks for testing and spotting the typo, BTW!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists