You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/06/25 06:34:29 UTC
[GitHub] [curator] eolivelli opened a new pull request #369: CURATOR-576 Import merge script from ZooKeeper project
eolivelli opened a new pull request #369:
URL: https://github.com/apache/curator/pull/369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-650778293
@Randgalt
Having a script helps the community in doing things all the same way and saves us from making errors.
We can make it non required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-650001733
Sorry @Randgalt for the confusion
I have sent an email to dev@curator.apache.org
This is the JIRA with full instructions (I have merged now the instructions that I sent on the ML)
https://issues.apache.org/jira/browse/CURATOR-576
The docs are here
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Merging+Github+Pull+Requests
we will have our own page once the script is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli merged pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #369:
URL: https://github.com/apache/curator/pull/369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] anmolnar commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
anmolnar commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-760474527
@Randgalt This script is super useful for ZooKeeper commits. It makes the process super fast and easy for everyone. Is it really better to keep scripts on a wiki instead of source control? People should use their own handmade rubbish instead of an official and well maintained script?
Sorry for horning in, this patch just caught my eye.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] Randgalt commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
Randgalt commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-650777651
I'm -1 on this. This can be run locally by someone interested in it. The scripts can live on our wiki. Personally, I wouldn't use them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] xianjeng21 commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
xianjeng21 commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-730793863
hmmmmm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] andrepappa commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
andrepappa commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-730775686
> What does this do?
what do you mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] Randgalt commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
Randgalt commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-649914073
What does this do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] Randgalt commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
Randgalt commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-761536766
OK, sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #369: CURATOR-576 Import merge script from ZooKeeper project
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #369:
URL: https://github.com/apache/curator/pull/369#issuecomment-762162859
@anmolnar @Randgalt
I am taking your discussion as finally "let's merge this script"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org