You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jablko <gi...@git.apache.org> on 2017/01/28 22:46:34 UTC
[GitHub] trafficserver pull request #1389: SSL_CTX_remove_session() and external cach...
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/1389
SSL_CTX_remove_session() and external cache
The remove session callback is triggered when a session is removed,
so at best, calling SSL_CTX_remove_session() again is redundant.
In OpenSSL 1.1 it's recursive.
Fixes #1386
My theory is that this worked by coincidence until [1]. Before that, if OpenSSL couldn't find the session in its internal cache, it wouldn't trigger the callback -- so since the session was already removed, SSL_CTX_remove_session() wouldn't trigger the callback again. Now it triggers the callback regardless.
[1] https://github.com/openssl/openssl/commit/e4612d02c53cccd24fa97b08fc01250d1238cca1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver remove_session
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1389
----
commit 6c8c00c074fe9d30249b2cacaff77eca9d41798e
Author: Jack Bates <ja...@nottheoilrig.com>
Date: 2017-01-28T22:25:31Z
SSL_CTX_remove_session() and external cache
The remove session callback is triggered when a session is removed,
so at best, calling SSL_CTX_remove_session() again is redundant.
In OpenSSL 1.1 it's recursive.
Fixes #1386
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1389: SSL_CTX_remove_session() and external cache
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1389
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1416/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1389: SSL_CTX_remove_session() and external cache
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1389
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1309/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1389: SSL_CTX_remove_session() and external cach...
Posted by jablko <gi...@git.apache.org>.
Github user jablko closed the pull request at:
https://github.com/apache/trafficserver/pull/1389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---