You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/09 11:08:16 UTC

[GitHub] [spark] olaky opened a new pull request, #36822: [SPARK-39259][SQL][3.0] Evaluate timestamps consistently in subqueries

olaky opened a new pull request, #36822:
URL: https://github.com/apache/spark/pull/36822

   ### What changes were proposed in this pull request?
   
   Apply the optimizer rule ComputeCurrentTime consistently across subqueries.
   
   This is a backport of https://github.com/apache/spark/pull/36654 with adjustements:
   * The rule does not use pruning
   * The transformWithSubqueries function was also backported
   
   ### Why are the changes needed?
   
   At the moment timestamp functions like now() can return different values within a query if subqueries are involved
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   A new unit test was added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #36822: [SPARK-39259][SQL][3.0] Evaluate timestamps consistently in subqueries

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36822: [SPARK-39259][SQL][3.0] Evaluate timestamps consistently in subqueries
URL: https://github.com/apache/spark/pull/36822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #36822: [SPARK-39259][SQL][3.0] Evaluate timestamps consistently in subqueries

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36822:
URL: https://github.com/apache/spark/pull/36822#issuecomment-1151878060

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #36822: [SPARK-39259][SQL][3.0] Evaluate timestamps consistently in subqueries

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36822:
URL: https://github.com/apache/spark/pull/36822#issuecomment-1152841485

   Could you make CIs happy, @olaky ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org