You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/14 10:43:31 UTC

[GitHub] [incubator-devlake-website] abeizn opened a new pull request, #120: fix: team configuration collect accounts

abeizn opened a new pull request, #120:
URL: https://github.com/apache/incubator-devlake-website/pull/120

   fix: team configuration collect accounts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake-website] abeizn commented on a diff in pull request #120: fix: team configuration collect accounts

Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #120:
URL: https://github.com/apache/incubator-devlake-website/pull/120#discussion_r921716260


##########
docs/UserManuals/TeamConfiguration.md:
##########
@@ -62,7 +62,7 @@ b. The actual api request.
 If there is a problem with team_users association or data in users, just re-put users api interface, i.e. (b in step 2 above)
 
 ## Step 4 - Collect accounts 

Review Comment:
   yes, I will add it, thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake-website] keon94 commented on a diff in pull request #120: fix: team configuration collect accounts

Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #120:
URL: https://github.com/apache/incubator-devlake-website/pull/120#discussion_r921337480


##########
docs/UserManuals/TeamConfiguration.md:
##########
@@ -62,7 +62,7 @@ b. The actual api request.
 If there is a problem with team_users association or data in users, just re-put users api interface, i.e. (b in step 2 above)
 
 ## Step 4 - Collect accounts 

Review Comment:
   Good writeup here. Are you constructing the fake account data by running SQL Insert statements? I think it'll help to also include them here to save the reader a couple of minutes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake-website] abeizn commented on a diff in pull request #120: fix: team configuration collect accounts

Posted by GitBox <gi...@apache.org>.
abeizn commented on code in PR #120:
URL: https://github.com/apache/incubator-devlake-website/pull/120#discussion_r921742533


##########
docs/UserManuals/TeamConfiguration.md:
##########
@@ -62,7 +62,7 @@ b. The actual api request.
 If there is a problem with team_users association or data in users, just re-put users api interface, i.e. (b in step 2 above)
 
 ## Step 4 - Collect accounts 

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake-website] abeizn merged pull request #120: fix: team configuration collect accounts

Posted by GitBox <gi...@apache.org>.
abeizn merged PR #120:
URL: https://github.com/apache/incubator-devlake-website/pull/120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org