You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/02/13 02:29:38 UTC

[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9286


Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters
......................................................................

IMPALA-6509: [docs] Note for haproxy for Kerberized clusters

Noted that after enabling ha-proxy in a kerberized cluster,
users can no-longer connect to individual impala daemons directly
from impala shell.

Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
---
M docs/topics/impala_proxy.xml
1 file changed, 12 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/9286/5
-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/203/


-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:35:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:35:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................

IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Noted that after enabling ha-proxy in a kerberized cluster,
users can no-longer connect to individual impala daemons directly
from impala shell.

Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Reviewed-on: http://gerrit.cloudera.org:8080/9286
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_proxy.xml
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Sailesh Mukil: Looks good to me, but someone else must approve
  John Russell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 5:

> Uploaded patch set 5: Patch Set 4 was rebased.

For what it's worth, https://gerrit.cloudera.org/c/7241 seems to be touching the same area of the world. If IMPALA-2782 gets resolved, we may want to change this text further.


-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Feb 2018 04:45:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9286/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9286/5//COMMIT_MSG@7
PS5, Line 7: docs
Uppercase "DOCS"


http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml@244
PS5, Line 244: k
Uppercase "Kerberized" is the convention we use elsewhere. You'll only see it lowercase in user-entered text like some JIRA titles.


http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml@247
PS5, Line 247: </note>
             :       </p>
Please put the note outside the paragraph, i.e.

<p>
  ...
</p>

<note>
...
</note>

It makes the output more predictable in terms of indentation and spacing, and is also friendlier from a maintenance perspective
because there's less indentation within the actual source file
(i.e. leaves more space on each line for actual text, leading to
less line wrapping).



-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Feb 2018 23:56:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Mar 2018 18:42:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 6: Code-Review+1

I'm good with this change. Demoting my +2 to a +1, since others are reviewing it.


-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Mar 2018 19:43:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Philip Zeyliger, Sailesh Mukil, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9286

to look at the new patch set (#6).

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................

IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Noted that after enabling ha-proxy in a kerberized cluster,
users can no-longer connect to individual impala daemons directly
from impala shell.

Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
---
M docs/topics/impala_proxy.xml
1 file changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/9286/6
-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 )

Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9286/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9286/5//COMMIT_MSG@7
PS5, Line 7: docs
> Uppercase "DOCS"
Done


http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:

http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml@244
PS5, Line 244: k
> Uppercase "Kerberized" is the convention we use elsewhere. You'll only see 
Done


http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml@247
PS5, Line 247: </note>
             :       </p>
> Please put the note outside the paragraph, i.e.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c
Gerrit-Change-Number: 9286
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Feb 2018 00:49:40 +0000
Gerrit-HasComments: Yes