You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/01/07 08:35:10 UTC

[GitHub] [netbeans] eirikbakke commented on pull request #3414: Support for image IDs, LSP client can redefine images/icons

eirikbakke commented on pull request #3414:
URL: https://github.com/apache/netbeans/pull/3414#issuecomment-1007228601


   I started looking through this, but I'm boarding a plane now and haven't finished reviewing yet...
   
   Adding URI in addition to URL seems to add a lot of complexity, and potential for confusion. Perhaps just add an optional String identifier, and then let icons be looked up by either the URL (if present) or the optional identifier?
   
   There's a number of hacks that could add complexity here... I remember dealing with icon/image wrappers when adding SVG support, and it was a source of pain.
   
   I will look more closely through this patch again in a day or two.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists