You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "vio-lin (via GitHub)" <gi...@apache.org> on 2023/02/15 06:29:13 UTC
[GitHub] [dubbo] vio-lin opened a new pull request, #11575: modify incorrect grpcConstants.
vio-lin opened a new pull request, #11575:
URL: https://github.com/apache/dubbo/pull/11575
## What is the purpose of the change
the grpc constans value is wrong.
`public static final String MAX_INBOUND_METADATA_SIZE = "grpc.maxInboundMetadataSize";`
## Brief changelog
1. modify incorrect grpcConstants.
## Verifying this change
GrpcConstants.java is saved with file which line sperator with CRLF .
我本地的格式应该是合理的。然后就是那条 Grpc 的分支应该不怎么用了。
但是这个静态变量 还是改一下。
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [x] GitHub Actions works fine on your own branch.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] vio-lin commented on pull request #11575: modify incorrect grpcConstants.
Posted by "vio-lin (via GitHub)" <gi...@apache.org>.
vio-lin commented on PR #11575:
URL: https://github.com/apache/dubbo/pull/11575#issuecomment-1437995153
> Please check in `3.2` branch. Master (2.7) branch is only for security fix now.
好哒
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed pull request #11575: modify incorrect grpcConstants.
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ closed pull request #11575: modify incorrect grpcConstants.
URL: https://github.com/apache/dubbo/pull/11575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org