You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 23:20:56 UTC

[GitHub] [arrow] sfc-gh-nthimmegowda commented on a diff in pull request #14359: ARROW-17450 : [C++][Parquet] Add support for uint8 boolean decode in addition to bool array

sfc-gh-nthimmegowda commented on code in PR #14359:
URL: https://github.com/apache/arrow/pull/14359#discussion_r992851767


##########
cpp/src/parquet/encoding.h:
##########
@@ -394,6 +394,12 @@ class DictDecoder : virtual public TypedDecoder<DType> {
 // ----------------------------------------------------------------------
 // TypedEncoder specializations, traits, and factory functions
 
+class BooleanDecoder : virtual public TypedDecoder<BooleanType> {
+ public:
+  using TypedDecoder<BooleanType>::Decode;
+  virtual int Decode(uint8_t* buffer, int max_values) = 0;

Review Comment:
   Done. Added a docstring. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org