[GitHub] merlimat commented on issue #744: Add user-defined properties to cursor position

[gi...@git.apache.org]

merlimat commented on issue #744: Add user-defined properties to cursor position
URL: https://github.com/apache/incubator-pulsar/pull/744#issuecomment-327653312
 
 
   (Replying here since I don't know why this doesn't show up on github)
   
   The lastMarkDeleteEntry is important to guarantee that we are storing the
   same couple of (mark-delete-pos, properties) together, even when we are
   rolling over the ledger.
   
   In many cases we would be picking up the last mark-delete op, though now we
   need to ensure they're together.
   
   On Wed, Sep 6, 2017 at 5:59 PM Rajan Dhabalia <no...@github.com>
   wrote:
   
   > *@rdhabalia* commented on this pull request.
   > ------------------------------
   >
   > In
   > managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
   > <https://github.com/apache/incubator-pulsar/pull/744#discussion_r137425890>
   > :
   >
   > > @@ -87,9 +90,10 @@
   >
   >      protected volatile PositionImpl markDeletePosition;
   >      protected volatile PositionImpl readPosition;
   > +    private volatile PendingMarkDeleteEntry lastMarkDeleteEntry;
   >
   > is it necessary to introduce lastMarkDeleteEntry field in this PR?
   >
   > ?
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pulsar/pull/744#pullrequestreview-61090737>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAD0JG7wyCAgrpVxVJr2iMToIqT1-2qgks5sf0AAgaJpZM4POqwn>
   > .
   >
   -- 
   Matteo Merli
   <mm...@apache.org>
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services