You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/03/26 14:33:16 UTC
[jira] [Commented] (CB-6346) [BlackBerry10] Commit node_modules
[ https://issues.apache.org/jira/browse/CB-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947905#comment-13947905 ]
ASF GitHub Bot commented on CB-6346:
------------------------------------
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/152
CB-6346 - Add node_modules to source control
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-blackberry addNodeModules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-blackberry/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 1139813cd8b7ee4b1a103ada5577cab79b2c39e6
Author: Bryan Higgins <br...@bryanhiggins.net>
Date: 2014-03-26T13:30:58Z
CB-6346 - Add node_modules to source control
----
> [BlackBerry10] Commit node_modules
> ----------------------------------
>
> Key: CB-6346
> URL: https://issues.apache.org/jira/browse/CB-6346
> Project: Apache Cordova
> Issue Type: Bug
> Components: BlackBerry
> Affects Versions: 3.4.0
> Reporter: Bryan Higgins
> Assignee: Bryan Higgins
> Fix For: 3.5.0
>
>
> We should commit node_modules for cordova-blackberry rather than running npm install within the init script. cordova-android has already moved to this model.
> https://www.npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git
--
This message was sent by Atlassian JIRA
(v6.2#6252)