You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "DM Smith (JIRA)" <ji...@apache.org> on 2008/07/11 19:26:31 UTC

[jira] Created: (LUCENE-1334) Term improvement

Term improvement
----------------

                 Key: LUCENE-1334
                 URL: https://issues.apache.org/jira/browse/LUCENE-1334
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Index
    Affects Versions: 2.3.1
         Environment: all
            Reporter: DM Smith
            Priority: Trivial
             Fix For: 2.4


Term is designed for reuse of the supplied filter, to minimize intern().

One of the common use patterns is to create a Term with the txt field being an empty string.

To simplify this pattern and to document it's usefulness, I suggest adding a constructor:
public Term(String fld)
with the obvious implementation
and use it throughout core and contrib as a replacement.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1334) Term improvement

Posted by "DM Smith (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

DM Smith updated LUCENE-1334:
-----------------------------

    Attachment: LUCENE-1334.txt

patch for the issue

> Term improvement
> ----------------
>
>                 Key: LUCENE-1334
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1334
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3.1
>         Environment: all
>            Reporter: DM Smith
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1334.txt
>
>
> Term is designed for reuse of the supplied filter, to minimize intern().
> One of the common use patterns is to create a Term with the txt field being an empty string.
> To simplify this pattern and to document it's usefulness, I suggest adding a constructor:
> public Term(String fld)
> with the obvious implementation
> and use it throughout core and contrib as a replacement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-1334) Term improvement

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1334.
----------------------------------------

    Resolution: Fixed

Thanks DM!

> Term improvement
> ----------------
>
>                 Key: LUCENE-1334
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1334
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3.1
>         Environment: all
>            Reporter: DM Smith
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1334.txt
>
>
> Term is designed for reuse of the supplied filter, to minimize intern().
> One of the common use patterns is to create a Term with the txt field being an empty string.
> To simplify this pattern and to document it's usefulness, I suggest adding a constructor:
> public Term(String fld)
> with the obvious implementation
> and use it throughout core and contrib as a replacement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1334) Term improvement

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reassigned LUCENE-1334:
------------------------------------------

    Assignee: Michael McCandless

> Term improvement
> ----------------
>
>                 Key: LUCENE-1334
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1334
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3.1
>         Environment: all
>            Reporter: DM Smith
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1334.txt
>
>
> Term is designed for reuse of the supplied filter, to minimize intern().
> One of the common use patterns is to create a Term with the txt field being an empty string.
> To simplify this pattern and to document it's usefulness, I suggest adding a constructor:
> public Term(String fld)
> with the obvious implementation
> and use it throughout core and contrib as a replacement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1334) Term improvement

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623627#action_12623627 ] 

Michael McCandless commented on LUCENE-1334:
--------------------------------------------

Patch looks good, thanks DM!  I'll commit shortly.

> Term improvement
> ----------------
>
>                 Key: LUCENE-1334
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1334
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3.1
>         Environment: all
>            Reporter: DM Smith
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: LUCENE-1334.txt
>
>
> Term is designed for reuse of the supplied filter, to minimize intern().
> One of the common use patterns is to create a Term with the txt field being an empty string.
> To simplify this pattern and to document it's usefulness, I suggest adding a constructor:
> public Term(String fld)
> with the obvious implementation
> and use it throughout core and contrib as a replacement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org