[jira] Commented: (SOLR-1674) improve analysis tests, cut over to new API

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924431#action_12924431 ] 

Mark Miller commented on SOLR-1674:
-----------------------------------

Going to close this if no one objects...

> improve analysis tests, cut over to new API
> -------------------------------------------
>
>                 Key: SOLR-1674
>                 URL: https://issues.apache.org/jira/browse/SOLR-1674
>             Project: Solr
>          Issue Type: Test
>          Components: Schema and Analysis
>            Reporter: Robert Muir
>            Assignee: Mark Miller
>             Fix For: 1.5, 3.1, 4.0
>
>         Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch
>
>
> This patch
> * converts all analysis tests to use the new tokenstream api
> * converts most tests to use the more stringent assertion mechanisms from lucene
> * adds new tests to improve coverage
> Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
> The problems with this filter are more serious, the previous tests were essentially a no-op.
> The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org