You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/04 18:59:17 UTC

[GitHub] [tvm] jwfromm opened a new pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

jwfromm opened a new pull request #7036:
URL: https://github.com/apache/tvm/pull/7036


   I recently encountered a model with that uses the MaxUnpool op, a pretty interesting operator that is designed to reverse a maxpool. I've added support for it in our frontend through some sneaky use of `scatter` and found that it matches onnx's execution for each special case of the operator.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7036:
URL: https://github.com/apache/tvm/pull/7036#issuecomment-740805808


   @masahi you're right that most models will use MaxUnpool with MaxPool returning indices, and we probably want to add that option to MaxPool operators soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7036:
URL: https://github.com/apache/tvm/pull/7036#issuecomment-740646243


   thanks @jwfromm 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7036:
URL: https://github.com/apache/tvm/pull/7036#issuecomment-739117727


   maybe it is time to upgrade ONNX and ORT on CI? We are at ONNX v1.6, while the latest is 1.8. Our ORT is hopelessly old: We are at 1.00 while the latest is 1.52.
   
   I can take a look at CI upgrade for ONNX this month @jwfromm. I did that for PyTorch last month.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7036:
URL: https://github.com/apache/tvm/pull/7036#issuecomment-738959304


   @masahi @mbrookhart can you guys take a look at this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7036:
URL: https://github.com/apache/tvm/pull/7036#issuecomment-740284637


   @masahi that would be nice, although in this case I was just being lazy and not calculating the output shape. I've fixed the test now if you want to take another look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7036:
URL: https://github.com/apache/tvm/pull/7036


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #7036: [Relay][Frontend][Onnx] MaxUnpool Operator

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7036:
URL: https://github.com/apache/tvm/pull/7036#issuecomment-739114999


   Whoops, I tested this with a newer version of onnxruntime that can do lenient shape merges. I'll fix the test to specify the expected output shape.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org