You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by asutosh936 <gi...@git.apache.org> on 2018/02/25 23:40:55 UTC

[GitHub] zookeeper pull request #473: ZOOKEEPER-2936 - Removed duplicate code

GitHub user asutosh936 opened a pull request:

    https://github.com/apache/zookeeper/pull/473

    ZOOKEEPER-2936 - Removed duplicate code

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/asutosh936/zookeeper master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/473.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #473
    
----
commit a02ef3db8d18cc738a1a3e24eafcaa0b5379d297
Author: asutosh936 <as...@...>
Date:   2018-02-25T23:40:14Z

    ZOOKEEPER-2936 - Removed duplicate code

----


---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Posted by anmolnar <gi...@git.apache.org>.

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/473
  
    @afine please take a look, I think this is ready to commit. thanks.


---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Posted by asutosh936 <gi...@git.apache.org>.

Github user asutosh936 commented on the issue:

    https://github.com/apache/zookeeper/pull/473
  
    Can someone please review and merge this PR.


---

[GitHub] zookeeper pull request #473: ZOOKEEPER-2936 - Removed duplicate code

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/473


---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Posted by asutosh936 <gi...@git.apache.org>.

Github user asutosh936 commented on the issue:

    https://github.com/apache/zookeeper/pull/473
  
    @anmolnar - Thanks for the Review.
    
    The issue is about having duplicate keys for ROLLINGFILE layout and conversion pattern. The fix is to remove the duplicate keys from the file. As rightly said there is no reason of commenting the code, instead deleting it. Please review.


---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Posted by asutosh936 <gi...@git.apache.org>.

Github user asutosh936 commented on the issue:

    https://github.com/apache/zookeeper/pull/473
  
    @anmolnar - Could You or someone from Your team please merge this PR?


---

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

Posted by afine <gi...@git.apache.org>.

Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/473
  
    Thanks @asutosh936!


---