[jira] [Comment Edited] (YARN-10596) Allow static definition of childless ParentQueues with auto-queue-creation-v2 enabled

["Peter Bacsko (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271342#comment-17271342 ] 

Peter Bacsko edited comment on YARN-10596 at 1/25/21, 2:38 PM:
---------------------------------------------------------------

[~gandras] I have a question.
{noformat}
 // Auto created parent queues might not have static children, but they
 // must be kept as a ParentQueue
 CSQueue oldQueue = oldQueues.get(fullQueueName);
 if (oldQueue instanceof ParentQueue) {
   isDynamicParent = ((ParentQueue) oldQueue).isDynamicQueue();
   isEligibleForAutoQueueCreation = ((ParentQueue) oldQueue).isDynamicQueue();
 }
{noformat}
Without explicitly saying if a queue is a parent or not, how do you distinguish between a parent with no leafs and an ordinary leaf queu? How do you detect that a queue with no children is intended to be a parent?


was (Author: pbacsko):
[~gandras] I have a question.

{noformat}
 // Auto created parent queues might not have static children, but they
 // must be kept as a ParentQueue
 CSQueue oldQueue = oldQueues.get(fullQueueName);
 if (oldQueue instanceof ParentQueue) {
 isDynamicParent = ((ParentQueue) oldQueue).isDynamicQueue();
 isEligibleForAutoQueueCreation = ((ParentQueue) oldQueue).isDynamicQueue();
 }
{noformat}

Without explicitly saying if a queue is a parent or not, how do you distinguish between a parent with no leafs and an ordinary leaf queu? How do you detect that a queue with no children is intended to be a parent?



> Allow static definition of childless ParentQueues with auto-queue-creation-v2 enabled
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-10596
>                 URL: https://issues.apache.org/jira/browse/YARN-10596
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Major
>         Attachments: YARN-10596.001.patch
>
>
> The old auto queue creation/managed queue logic allowed the definition of childless parents to be created statically, if the auto-create-child-queue flag was turned on the parent (thus making it a ManagedParentQueue).
> Since it is not an edge case, we also need to support the creation of a ParentQueue instead of a LeafQueue, if auto-queue-creation-v2 is enabled, even when no child queue is defined under the parent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org