You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomee.apache.org by dave <d....@alchemy.co.nz> on 2015/10/17 05:07:32 UTC
tomee:exec on Windows produces invalid tomee.zip due to backslash
directory separators
Hi, I am trying to use tomee:exec to produce a self-contained jar under
Windows, but running this under Linux. The tomee.zip file produced in the
jar uses backslash for directory separators which doesn't unpack correctly
under Linux. For example the Zip entry 'conf\tomee.xml' is unpacked to a
file called 'conf\tomee.xml' rather than a file called 'tomee.xml' in the
directory conf.
>From what I have read a Zip file should always use forward slashes for
directory separators (see section 4.4.17 at
https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT), but
org.apache.openejb.maven.plugin.util.Zips uses the platform directory
separator. I have implemented a fix for Zips.java and tested this
stand-alone, but currently don't have a fully set up environment to build
and test the Maven plugin.
I have filed a bug with a patch to fix this and a unit test. See
https://issues.apache.org/jira/browse/TOMEE-1638
Regards,
Dave
--
View this message in context: http://tomee-openejb.979440.n4.nabble.com/tomee-exec-on-Windows-produces-invalid-tomee-zip-due-to-backslash-directory-separators-tp4676522.html
Sent from the TomEE Users mailing list archive at Nabble.com.
Re: tomee:exec on Windows produces invalid tomee.zip due to backslash
directory separators
Posted by Romain Manni-Bucau <rm...@gmail.com>.
think the issue is solved with 7.0.0-SNAPSHOT, can you try it before we go
further?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>
2015-10-17 10:58 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> Hi Dave
>
> Your patch looks very valid
>
> Ill test it under unix then integrate it if working
>
> Thanks a lot!
> Le 17 oct. 2015 05:18, "dave" <d....@alchemy.co.nz> a écrit :
>
>> Hi, I am trying to use tomee:exec to produce a self-contained jar under
>> Windows, but running this under Linux. The tomee.zip file produced in the
>> jar uses backslash for directory separators which doesn't unpack correctly
>> under Linux. For example the Zip entry 'conf\tomee.xml' is unpacked to a
>> file called 'conf\tomee.xml' rather than a file called 'tomee.xml' in the
>> directory conf.
>>
>> From what I have read a Zip file should always use forward slashes for
>> directory separators (see section 4.4.17 at
>> https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT), but
>> org.apache.openejb.maven.plugin.util.Zips uses the platform directory
>> separator. I have implemented a fix for Zips.java and tested this
>> stand-alone, but currently don't have a fully set up environment to build
>> and test the Maven plugin.
>>
>> I have filed a bug with a patch to fix this and a unit test. See
>> https://issues.apache.org/jira/browse/TOMEE-1638
>>
>> Regards,
>> Dave
>>
>>
>>
>> --
>> View this message in context:
>> http://tomee-openejb.979440.n4.nabble.com/tomee-exec-on-Windows-produces-invalid-tomee-zip-due-to-backslash-directory-separators-tp4676522.html
>> Sent from the TomEE Users mailing list archive at Nabble.com.
>>
>
Re: tomee:exec on Windows produces invalid tomee.zip due to backslash
directory separators
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Dave
Your patch looks very valid
Ill test it under unix then integrate it if working
Thanks a lot!
Le 17 oct. 2015 05:18, "dave" <d....@alchemy.co.nz> a écrit :
> Hi, I am trying to use tomee:exec to produce a self-contained jar under
> Windows, but running this under Linux. The tomee.zip file produced in the
> jar uses backslash for directory separators which doesn't unpack correctly
> under Linux. For example the Zip entry 'conf\tomee.xml' is unpacked to a
> file called 'conf\tomee.xml' rather than a file called 'tomee.xml' in the
> directory conf.
>
> From what I have read a Zip file should always use forward slashes for
> directory separators (see section 4.4.17 at
> https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT), but
> org.apache.openejb.maven.plugin.util.Zips uses the platform directory
> separator. I have implemented a fix for Zips.java and tested this
> stand-alone, but currently don't have a fully set up environment to build
> and test the Maven plugin.
>
> I have filed a bug with a patch to fix this and a unit test. See
> https://issues.apache.org/jira/browse/TOMEE-1638
>
> Regards,
> Dave
>
>
>
> --
> View this message in context:
> http://tomee-openejb.979440.n4.nabble.com/tomee-exec-on-Windows-produces-invalid-tomee-zip-due-to-backslash-directory-separators-tp4676522.html
> Sent from the TomEE Users mailing list archive at Nabble.com.
>