[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34008: [SPARK-36767][SQL] ArrayMin/ArrayMax/SortArray/ArraySort add comment and Unit test

[GitBox <gi...@apache.org>]

AngersZhuuuu commented on a change in pull request #34008:
URL: https://github.com/apache/spark/pull/34008#discussion_r709891252



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -916,7 +916,7 @@ object ArraySortLike {
     _FUNC_(array[, ascendingOrder]) - Sorts the input array in ascending or descending order
       according to the natural ordering of the array elements. Null elements will be placed
       at the beginning of the returned array in ascending order or at the end of the returned
-      array in descending order.
+      array in descending order. NaN is greater than any non-NaN value for DoubleType/FloatType.

Review comment:
       > I think we should mention NaN before null.
   
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org