You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/02/04 15:09:28 UTC
[GitHub] [fineract] xurror opened a new pull request #708: FINERACT-840 -
Replace demo.openmf.org/api-docs
xurror opened a new pull request #708: FINERACT-840 - Replace demo.openmf.org/api-docs
URL: https://github.com/apache/fineract/pull/708
Update API docs and demo app URL
## Description
Someone pointed out on the mailing list that https://demo.openmf.org/api-docs/apiLive.htm, which we currently link to from https://github.com/apache/fineract#apache-fineract-platform-api, is down; quote: "I've checked a number of times over the past couple weeks and it
seems that's always been the case.")
We should fix that.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #708: FINERACT-840 -
Replace demo.openmf.org/api-docs
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #708: FINERACT-840 - Replace demo.openmf.org/api-docs
URL: https://github.com/apache/fineract/pull/708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on a change in pull request #708:
FINERACT-840 - Replace demo.openmf.org/api-docs
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #708: FINERACT-840 - Replace demo.openmf.org/api-docs
URL: https://github.com/apache/fineract/pull/708#discussion_r374970782
##########
File path: docs/system-architecture/index.html
##########
@@ -233,7 +233,7 @@ <h4>History</h4>
<ul>
<li>2006: Project intiated by <a href="http://www.grameenfoundation.org/" target="_blank">Grameen Foundation</a></li>
<li>Late 2011: Grameen Foundation handed over full responsibility to open source community.</li>
- <li>2012: Mifos X platform started. Previous members of project come together under the name of Community for Open Source Microfinance (COSM / <a href="http://www.openmf.org" target="_blank">OpenMF</a>)</li>
+ <li>2012: Mifos X platform started. Previous members of project come together under the name of Community for Open Source Microfinance (COSM / <a href="http://www.mifos.io" target="_blank">OpenMF</a>)</li>
Review comment:
alright
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on a change in pull request #708:
FINERACT-840 - Replace demo.openmf.org/api-docs
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #708: FINERACT-840 - Replace demo.openmf.org/api-docs
URL: https://github.com/apache/fineract/pull/708#discussion_r374737405
##########
File path: docs/system-architecture/index.html
##########
@@ -233,7 +233,7 @@ <h4>History</h4>
<ul>
<li>2006: Project intiated by <a href="http://www.grameenfoundation.org/" target="_blank">Grameen Foundation</a></li>
<li>Late 2011: Grameen Foundation handed over full responsibility to open source community.</li>
- <li>2012: Mifos X platform started. Previous members of project come together under the name of Community for Open Source Microfinance (COSM / <a href="http://www.openmf.org" target="_blank">OpenMF</a>)</li>
+ <li>2012: Mifos X platform started. Previous members of project come together under the name of Community for Open Source Microfinance (COSM / <a href="http://www.mifos.io" target="_blank">OpenMF</a>)</li>
Review comment:
use: `www.mifos.org` here instead of mifos.io (as it does not have any content)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #708: FINERACT-840 - Replace
demo.openmf.org/api-docs
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #708: FINERACT-840 - Replace demo.openmf.org/api-docs
URL: https://github.com/apache/fineract/pull/708#issuecomment-583832923
I just noticed I failed to update the links in the API docs. Link to reference app in documentation still redirects us https://demo.openmf.org instead of https://demo.mifos.io
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #708: FINERACT-840 - Replace
demo.openmf.org/api-docs
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #708: FINERACT-840 - Replace demo.openmf.org/api-docs
URL: https://github.com/apache/fineract/pull/708#issuecomment-592931019
> I just noticed I failed to update the links in the API docs. Link to reference app in documentation still redirects us https://demo.openmf.org instead of https://demo.mifos.io
Have u sent a new PR for this? @xurror
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services