You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/18 19:50:49 UTC

[GitHub] [flink] xuefuz commented on a change in pull request #8784: [FLINK-12892][table][hive] serialize catalog table to properties for table discovery service

xuefuz commented on a change in pull request #8784: [FLINK-12892][table][hive] serialize catalog table to properties for table discovery service
URL: https://github.com/apache/flink/pull/8784#discussion_r294998015
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
 ##########
 @@ -103,6 +103,18 @@ public void putProperties(DescriptorProperties otherProperties) {
 		}
 	}
 
+	/**
+	 * Adds a properties map by appending the given prefix to element keys.
+	 */
 
 Review comment:
   Complete the javadoc as this is going to be a public method. Same for get.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services