You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "liaoyt (via GitHub)" <gi...@apache.org> on 2025/11/04 14:48:11 UTC
[PR] [AMORO-3885] fix missing oss.endpoint for internal mixed_iceberg catalog [amoro]
liaoyt opened a new pull request, #3886:
URL: https://github.com/apache/amoro/pull/3886
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #3885.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3885] fix missing oss.endpoint for internal mixed_iceberg catalog [amoro]
Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #3886:
URL: https://github.com/apache/amoro/pull/3886#discussion_r2497119730
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -500,7 +500,8 @@ private CatalogMeta constructCatalogMeta(CatalogRegisterInfo info, CatalogMeta o
STORAGE_CONFIGS_KEY_S3_ENDPOINT,
S3FileIOProperties.ENDPOINT);
} else if (storageType.equals(STORAGE_CONFIGS_VALUE_TYPE_OSS)) {
- if (TableFormat.valueOf(tableFormats) == TableFormat.ICEBERG) {
+ if (Arrays.asList(TableFormat.ICEBERG, TableFormat.MIXED_ICEBERG)
Review Comment:
`tableFormats` would be a string variable that contains multiple table formats like `ICEBERG,MIXED_ICEBERG,PAIMON`. We may change the code here to `info.getTableFormatList().contains(ICEBERG.name()) || info.getTableFormatList().contains(MIXED_ICEBERG.name())`.
HDYT?
BTW, the line 509 should be fixed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3885] fix missing oss.endpoint for internal mixed_iceberg catalog [amoro]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3886:
URL: https://github.com/apache/amoro/pull/3886#issuecomment-3486397668
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3886?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 22.13%. Comparing base ([`17b68d0`](https://app.codecov.io/gh/apache/amoro/commit/17b68d01db1c34452c39c6fd9ee972955b9f4a16?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3f63e7a`](https://app.codecov.io/gh/apache/amoro/commit/3f63e7aa96f79da24c32a838aa89c88c7dd4cb8f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (17b68d0) and HEAD (3f63e7a). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (17b68d0) | HEAD (3f63e7a) |
>|------|------|------|
>|core|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3886 +/- ##
============================================
- Coverage 28.82% 22.13% -6.69%
+ Complexity 3838 2461 -1377
============================================
Files 625 444 -181
Lines 50514 40883 -9631
Branches 6455 5766 -689
============================================
- Hits 14560 9050 -5510
+ Misses 34928 31075 -3853
+ Partials 1026 758 -268
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/3886/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core](https://app.codecov.io/gh/apache/amoro/pull/3886/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [trino](https://app.codecov.io/gh/apache/amoro/pull/3886/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.13% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3886?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3885] fix missing oss.endpoint for internal mixed_iceberg catalog [amoro]
Posted by "liaoyt (via GitHub)" <gi...@apache.org>.
liaoyt commented on code in PR #3886:
URL: https://github.com/apache/amoro/pull/3886#discussion_r2506340700
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -500,7 +500,8 @@ private CatalogMeta constructCatalogMeta(CatalogRegisterInfo info, CatalogMeta o
STORAGE_CONFIGS_KEY_S3_ENDPOINT,
S3FileIOProperties.ENDPOINT);
} else if (storageType.equals(STORAGE_CONFIGS_VALUE_TYPE_OSS)) {
- if (TableFormat.valueOf(tableFormats) == TableFormat.ICEBERG) {
+ if (Arrays.asList(TableFormat.ICEBERG, TableFormat.MIXED_ICEBERG)
Review Comment:
you are right, i had fixed this and also the get catalog detail interface should be fixed too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3885] fix missing oss.endpoint for internal mixed_iceberg catalog [amoro]
Posted by "czy006 (via GitHub)" <gi...@apache.org>.
czy006 merged PR #3886:
URL: https://github.com/apache/amoro/pull/3886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org