You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/18 20:59:05 UTC
[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3086: [HUDI-1776] Support AlterCommand For Hoodie
pengzhiwei2018 commented on a change in pull request #3086:
URL: https://github.com/apache/hudi/pull/3086#discussion_r654097033
##########
File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.types.{LongType, StructField, StructType}
+
+class TestAlterTable extends TestHoodieSqlBase {
+
+ test("Test Alter Table") {
+ withTempDir { tmp =>
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ val tablePath = s"${tmp.getCanonicalPath}/$tableName"
+ // Create table
+ spark.sql(
+ s"""
+ |create table $tableName (
+ | id int,
+ | name string,
+ | price double,
+ | ts long
+ |) using hudi
+ | location '$tablePath'
+ | options (
+ | type = '$tableType',
+ | primaryKey = 'id',
+ | preCombineField = 'ts'
+ | )
+ """.stripMargin)
+ // Alter table name.
+ val newTableName = s"${tableName}_1"
+ spark.sql(s"alter table $tableName rename to $newTableName")
+ assertResult(true) (
+ spark.sessionState.catalog.tableExists(new TableIdentifier(newTableName))
+ )
+ val hadoopConf = spark.sessionState.newHadoopConf()
+ val metaClient = HoodieTableMetaClient.builder().setBasePath(tablePath)
+ .setConf(hadoopConf).build()
+ assertResult(newTableName) (
+ metaClient.getTableConfig.getTableName
+ )
+
+ spark.sql(s"insert into $newTableName values(1, 'a1', 10, 1000)")
+
+ // Add table column
+ spark.sql(s"alter table $newTableName add columns(ext0 string)")
+ val table = spark.sessionState.catalog.getTableMetadata(new TableIdentifier(newTableName))
+ assertResult(Seq("id", "name", "price", "ts", "ext0")) {
+ HoodieSqlUtils.removeMetaFields(table.schema).fields.map(_.name)
+ }
+ checkAnswer(s"select id, name, price, ts, ext0 from $newTableName")(
+ Seq(1, "a1", 10.0, 1000, null)
+ )
+ // Alter table column type
+ spark.sql(s"alter table $newTableName change column id id bigint")
+ assertResult(StructType(Seq(StructField("id", LongType, nullable = true))))(
+ spark.sql(s"select id from $newTableName").schema)
+
+
+ // Insert data to the new table.
+ spark.sql(s"insert into $newTableName values(2, 'a2', 12, 1000, 'e0')")
Review comment:
No, the new table's schema has changed, the insert statement must match the new table's schema. So we can not missing the `ext0` column.
##########
File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTable.scala
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+import org.apache.hudi.common.table.HoodieTableMetaClient
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.types.{LongType, StructField, StructType}
+
+class TestAlterTable extends TestHoodieSqlBase {
+
+ test("Test Alter Table") {
+ withTempDir { tmp =>
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ val tablePath = s"${tmp.getCanonicalPath}/$tableName"
+ // Create table
+ spark.sql(
+ s"""
+ |create table $tableName (
+ | id int,
+ | name string,
+ | price double,
+ | ts long
+ |) using hudi
+ | location '$tablePath'
+ | options (
+ | type = '$tableType',
+ | primaryKey = 'id',
+ | preCombineField = 'ts'
+ | )
+ """.stripMargin)
+ // Alter table name.
+ val newTableName = s"${tableName}_1"
+ spark.sql(s"alter table $tableName rename to $newTableName")
+ assertResult(true) (
+ spark.sessionState.catalog.tableExists(new TableIdentifier(newTableName))
Review comment:
Make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org