You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Krasilnikov <in...@gmail.com> on 2011/07/14 15:56:11 UTC
[PATCH] Issue 3959: Uninitialized value warning in bindings/swig/perl/native/Core.pm
When using git-svn I frequently see the following warning in
subversion's perl bindings after a network error:
Use of uninitialized value in concatenation (.) or string at <...>/SVN/Core.pm
line 584.
Attached patch eliminates this warning.
Re: [PATCH] Issue 3959: Uninitialized value warning in
bindings/swig/perl/native/Core.pm
Posted by Peter Samuelson <pe...@p12n.org>.
[Ivan Krasilnikov]
> Looks like this issue only affects svn+ssh:// repositories. I've just
> tried cloning some public http(s):// repositories and firewalling
> destination host with iptables - didn't get the warning. But it
> appears reliably every time when I'm git svn fetch'ing from an
> svn+ssh:// repository.
Thanks, yes, that works. Just voted for the patch, so it will probably
go into 1.7.0.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
Re: [PATCH] Issue 3959: Uninitialized value warning in bindings/swig/perl/native/Core.pm
Posted by Ivan Krasilnikov <in...@gmail.com>.
On Fri, Jul 15, 2011 at 06:07, Peter Samuelson <pe...@p12n.org> wrote:
>
> [Ivan Krasilnikov]
>> When using git-svn I frequently see the following warning in
>> subversion's perl bindings after a network error:
>>
>> Use of uninitialized value in concatenation (.) or string at <...>/SVN/Core.pm
>> line 584.
>
> Just to verify that we've addressed the error correctly, I'm trying to
> reproduce it, and I can't. (I've been trying to simulate network
> errors with Linux iptables.) What kinds of network errors cause this
> warning, and what 'git svn' commands are you using?
Looks like this issue only affects svn+ssh:// repositories. I've just
tried cloning some public http(s):// repositories and firewalling
destination host with iptables - didn't get the warning. But it
appears reliably every time when I'm git svn fetch'ing from an
svn+ssh:// repository.
Re: [PATCH] Issue 3959: Uninitialized value warning in
bindings/swig/perl/native/Core.pm
Posted by Peter Samuelson <pe...@p12n.org>.
[Ivan Krasilnikov]
> When using git-svn I frequently see the following warning in
> subversion's perl bindings after a network error:
>
> Use of uninitialized value in concatenation (.) or string at <...>/SVN/Core.pm
> line 584.
Just to verify that we've addressed the error correctly, I'm trying to
reproduce it, and I can't. (I've been trying to simulate network
errors with Linux iptables.) What kinds of network errors cause this
warning, and what 'git svn' commands are you using?
Thanks,
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
Re: [PATCH] Issue 3959: Uninitialized value warning in
bindings/swig/perl/native/Core.pm
Posted by Peter Samuelson <pe...@p12n.org>.
[Ivan Krasilnikov]
> Use of uninitialized value in concatenation (.) or string at <...>/SVN/Core.pm
> line 584.
>
> Attached patch eliminates this warning.
Thanks, r1146834.
--
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/