You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/01/30 03:24:31 UTC
Review Request 17524: Add one integration test for the new producer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1233
https://issues.apache.org/jira/browse/KAFKA-1233
Repository: kafka
Description
-------
KAFKA-1233.v1
Diffs
-----
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
Diff: https://reviews.apache.org/r/17524/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 17524: Add one integration test for the new producer
Posted by Guozhang Wang <gu...@linkedin.com>.
> On Jan. 30, 2014, 6:12 p.m., Jun Rao wrote:
> > Could you build a release tar and make sure that we don't drag in the new client jar as a dependency?
./sbt release-tar failed due to ambiguous references:
[error] it is imported twice in the same scope by
[error] import kafka.common._
[error] and import kafka.cluster._
I think this also indicates that the jar is included..
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/#review33232
-----------------------------------------------------------
On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17524/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 2:24 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1233
> https://issues.apache.org/jira/browse/KAFKA-1233
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1233.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
> project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
>
> Diff: https://reviews.apache.org/r/17524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 17524: Add one integration test for the new producer
Posted by Guozhang Wang <gu...@linkedin.com>.
> On Jan. 30, 2014, 6:12 p.m., Jun Rao wrote:
> > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, lines 75-76
> > <https://reviews.apache.org/r/17524/diff/1/?file=454164#file454164line75>
> >
> > Do we really want to print those out in an integration test?
I used this for checking the send.offset functionality. I think I can just use one callback that really prints the offset, and the rest for no-op.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/#review33232
-----------------------------------------------------------
On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17524/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 2:24 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1233
> https://issues.apache.org/jira/browse/KAFKA-1233
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1233.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
> project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
>
> Diff: https://reviews.apache.org/r/17524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 17524: Add one integration test for the new producer
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/#review33232
-----------------------------------------------------------
Could you build a release tar and make sure that we don't drag in the new client jar as a dependency?
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala
<https://reviews.apache.org/r/17524/#comment62598>
Do we really want to print those out in an integration test?
- Jun Rao
On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17524/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 2:24 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1233
> https://issues.apache.org/jira/browse/KAFKA-1233
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1233.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
> project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
>
> Diff: https://reviews.apache.org/r/17524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 17524: Add one integration test for the new producer
Posted by Guozhang Wang <gu...@linkedin.com>.
> On Jan. 30, 2014, 5:02 p.m., Jay Kreps wrote:
> > This is a very nice test! It would be good to also have a scenario that has two servers with a replication-factor two topic and kills one of the servers to validate the reconnect/metadata logic.
Yeah I plan to have the replication scenario in another test class, this one is mainly for producer API.
> On Jan. 30, 2014, 5:02 p.m., Jay Kreps wrote:
> > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala, line 54
> > <https://reviews.apache.org/r/17524/diff/1/?file=454164#file454164line54>
> >
> > Might as well bump this up to 1000 since the test time will be dominated by setup/teardown (I suspect) and this will allow a few batched requests to be accumulated which is a little more aggressive.
ack
> On Jan. 30, 2014, 5:02 p.m., Jay Kreps wrote:
> > project/Build.scala, line 144
> > <https://reviews.apache.org/r/17524/diff/1/?file=454165#file454165line144>
> >
> > I just want to double check that you validated this doesn't cause the jar to show up in the release and won't impact the maven deps if we do a release...
./sbt release-tar failed due to ambiguous references:
[error] it is imported twice in the same scope by
[error] import kafka.common._
[error] and import kafka.cluster._
I think this also indicates that the jar is included..
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/#review33225
-----------------------------------------------------------
On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17524/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 2:24 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1233
> https://issues.apache.org/jira/browse/KAFKA-1233
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1233.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
> project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
>
> Diff: https://reviews.apache.org/r/17524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 17524: Add one integration test for the new producer
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17524/#review33225
-----------------------------------------------------------
Ship it!
This is a very nice test! It would be good to also have a scenario that has two servers with a replication-factor two topic and kills one of the servers to validate the reconnect/metadata logic.
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala
<https://reviews.apache.org/r/17524/#comment62584>
Might as well bump this up to 1000 since the test time will be dominated by setup/teardown (I suspect) and this will allow a few batched requests to be accumulated which is a little more aggressive.
project/Build.scala
<https://reviews.apache.org/r/17524/#comment62585>
I just want to double check that you validated this doesn't cause the jar to show up in the release and won't impact the maven deps if we do a release...
- Jay Kreps
On Jan. 30, 2014, 2:24 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17524/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 2:24 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1233
> https://issues.apache.org/jira/browse/KAFKA-1233
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1233.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
> project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
>
> Diff: https://reviews.apache.org/r/17524/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>