You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2004/06/30 06:48:30 UTC

Re: svn commit: r10105 - trunk

rey4@tigris.org wrote:

>Author: rey4
>Date: Tue Jun 29 18:50:29 2004
>New Revision: 10105
>
>Modified:
>   trunk/build.conf
>Log:
>Update swig dependencies
>
>* build.conf
>  (swig_runtime):
>    add apr dependency (perl bindings use apr_time_now)
>  
>
Doesn't Perl have an equivalent function that the bimdings could use?

-- Brane


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r10105 - trunk

Posted by Ben Reser <be...@reser.org>.
On Wed, Jun 30, 2004 at 09:04:47AM -0400, Russell Yanofsky wrote:
> Branko ÄOibej wrote:
> > rey4@tigris.org wrote:
> >> * build.conf
> >>  (swig_runtime):
> >>    add apr dependency (perl bindings use apr_time_now)
> >>
> >>
> > Doesn't Perl have an equivalent function that the bimdings could use?
> 
> I don't know. The call to apr_time_now isn't new, this change was just
> neccessary because the perl bindings gave link errors with the issue #1627
> patches applied.

We do, but this is in the C side of the code and is used in a call to
svn_parse_date(), which wants an apr_time_t.  I'd have to jump through a
lot of hoops to call Perl's time() call, which of course may only
provide a 32-bit value or call the systems time() call which has the
same issue.  Thus apr_time_now() is the best option.

-- 
Ben Reser <be...@reser.org>
http://ben.reser.org

"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r10105 - trunk

Posted by Russell Yanofsky <re...@columbia.edu>.
Branko ÄOibej wrote:
> rey4@tigris.org wrote:
>> * build.conf
>>  (swig_runtime):
>>    add apr dependency (perl bindings use apr_time_now)
>>
>>
> Doesn't Perl have an equivalent function that the bimdings could use?

I don't know. The call to apr_time_now isn't new, this change was just
neccessary because the perl bindings gave link errors with the issue #1627
patches applied.

- Russ



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org