You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by aniketadnaik <gi...@git.apache.org> on 2016/10/20 02:06:53 UTC
[GitHub] incubator-carbondata pull request #250: CARBONDATA-330: Fix compiler warning...
GitHub user aniketadnaik opened a pull request:
https://github.com/apache/incubator-carbondata/pull/250
CARBONDATA-330: Fix compiler warnings
Removed some compilation warnings in Java code and scala tests.
Not all warning can be removed at this point as some them may require code change that may impact the functionality.
**Please provide details on**
**- Whether new unit test cases have been added or why no new tests are required?**
Not Required. No change in functionality.
**- What manual testing you have done?**
Basic carbon examples + "mvn clean verify"
**- Any additional information to help reviewers in testing this change.**
No
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aniketadnaik/incubator-carbondata code-cleanup-carbon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit 9b3fc90c8b92330a3d363861e7771054ca475354
Author: aniket <an...@huawei.com>
Date: 2016-10-20T01:36:12Z
CARBONDATA-330: Fix compiler warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #250: CARBONDATA-330: Fix compiler warning...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #250: CARBONDATA-330: Fix compiler warning...
Posted by aniketadnaik <gi...@git.apache.org>.
Github user aniketadnaik commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/250#discussion_r85031862
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala ---
@@ -223,7 +223,7 @@ case class CarbonDictionaryDecoder(
atiMap.get(f._1).get.getCarbonTableIdentifier,
f._2, f._3))
} catch {
- case _ => null
+ case _ : Throwable => null
--- End diff --
Fixed review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---