You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Robert Tucker (JIRA)" <ji...@apache.org> on 2008/06/03 10:18:45 UTC
[jira] Created: (SLING-500) The Dojo Toolkit bundle doesn't include
the Dojo source files
The Dojo Toolkit bundle doesn't include the Dojo source files
-------------------------------------------------------------
Key: SLING-500
URL: https://issues.apache.org/jira/browse/SLING-500
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: 2.0.0
Reporter: Robert Tucker
Priority: Minor
The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601952#action_12601952 ]
Lars Trieloff commented on SLING-500:
-------------------------------------
A fairy told me my feedback is required here. I will have a look at it as soon as I have a decent internet connection and some time to concentrate.
To clarify one thing: what we want to achieve is a 16MB bundle containing all dojo sources, right. Only that Felix gets this result without the patch and Robert needs the patch. Or is there anything I have been missing?
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Robert Tucker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602136#action_12602136 ]
Robert Tucker commented on SLING-500:
-------------------------------------
The checksum did indeed fail. I deleted the file from the download cache, re-ran mvn clean install and now all is right with the world. Thanks again for everyone's help!
Question on process: Should I close this now or leave open in case someone wants to apply Lars' patch?
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-500-verify-download.patch, sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Craig L. Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601963#action_12601963 ]
Craig L. Ching commented on SLING-500:
--------------------------------------
Yeah, I didn't see this problem either. Maybe I'm misunderstanding, but he says the source isn't there, that would mean that dojo (and the SlingNodeStore and SlingPropertyStore as well) wouldn't work at all, right? Or is there something I'm missing, he does say it's minor so I'm wondering if there is something I'm not understanding.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-500) The Dojo Toolkit bundle doesn't include
the Dojo source files
Posted by "Robert Tucker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Tucker updated SLING-500:
--------------------------------
Attachment: sling-500.patch
A patch to fix this is included.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601943#action_12601943 ]
Felix Meschberger commented on SLING-500:
-----------------------------------------
> - expanding the Dojo sources to: sling/extensions/dojo/target/dojo/dojo-release-1.1.0 and
On my system, the library is unpacked into sling/extensions/dojo/target/dojo/dojo-release-1.1.0-src and the the hostenv_rhino.js is correctly overwritten there.
Finally the thing is packed into the bundle, yielding a bundle of 16MB.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Robert Tucker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601937#action_12601937 ]
Robert Tucker commented on SLING-500:
-------------------------------------
Yay! What do I win? ;-)
Perhaps it is just me. Prior to patching my pom, the build was:
- expanding the Dojo sources to: sling/extensions/dojo/target/dojo/dojo-release-1.1.0 and
- copying src/main/dojo-override to: sling/extensions/dojo/target/dojo/dojo-release-1.1.0-src
Because the bundle was only including "${dojo.target}/dojo-${dojo.version}-src", the Dojo sources were not making it into the bundle. An alternative to my patch would be to keep the "-src" designation and update the untar step.
Either way, this is a minor issue, so I have no problem waiting for Lars' feedback. Thanks for your prompt response.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-500) The Dojo Toolkit bundle doesn't include
the Dojo source files
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Trieloff updated SLING-500:
--------------------------------
Attachment: SLING-500-verify-download.patch
This patch adds MD5 checksum verification to the build file. So if your ZIP file download gets corrupted, Maven will fail, forcing you to solve the problem. Additionally we can make sure that no evildoer replaces the dojo sources at the dojo download server without us noticing it.
Robert, what are your results after using this patch?
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-500-verify-download.patch, sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Lars Trieloff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602069#action_12602069 ]
Lars Trieloff commented on SLING-500:
-------------------------------------
Robert, is it possible that your download-cache is for some reason corrupted? Anyway I think it might be a good idea to add a checksum verification to the ant tasks to make sure the correct version of dojo is being downloaded.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-500.
-------------------------------------
Resolution: Fixed
I applied the Lars Trieloff's patch with a slightly modified failure message indicating where to look for the problem in Rev. 663008.
Please close this isssue if your problem is solved. Thanks.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-500-verify-download.patch, sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-500:
---------------------------------------
Assignee: Felix Meschberger
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601958#action_12601958 ]
Bertrand Delacretaz commented on SLING-500:
-------------------------------------------
FWIW, I also get a 16MB /dojo/target/org.apache.sling.extensions.dojo-1.1.0.001-incubator-SNAPSHOT.jar after running "mvn clean install" either from the top-level sling directory, or from extensions/dojo.
I'm using Maven 2.0.7, on macosx - Robert, what's your environment?
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Robert Tucker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601992#action_12601992 ]
Robert Tucker commented on SLING-500:
-------------------------------------
>mvn --version
Maven version: 2.0.9
Java version: 1.5.0_13
OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
I reverted the pom and got:
>mvn clean install
[...snip...]
[INFO] Executing tasks
[mkdir] Created dir: C:\Projects\sling\extensions\dojo\target\dojo
[get] Getting: http://download.dojotoolkit.org/release-1.1.0/dojo-release-1.1.0-src.tar.gz
[get] To: C:\Projects\sling\extensions\dojo\download-cache\dojo-release-1.1.0-src.tar.gz
[get] Not modified - so not downloaded
[untar] Expanding: C:\Projects\sling\extensions\dojo\download-cache\dojo-release-1.1.0-src.tar.gz into C:\Projects\sling\extensions\dojo\target\dojo
[copy] Copying 1 file to C:\Projects\sling\extensions\dojo\target\dojo\dojo-release-1.1.0-src
[...snip...]
Wierd thing is that I have 2 directories under sling/extensions/dojo/target/dojo:
>dir /d
Directory of C:\Projects\sling\extensions\dojo\target\dojo
[.] [dojo-release-1.1.0] <-- Dojo sources expanded here
[..] [dojo-release-1.1.0-src] <-- override here
Both jars are < 30KB:
>dir
Directory of C:\Projects\sling\extensions\dojo\target
06/03/2008 12:10 PM <DIR> .
06/03/2008 12:10 PM <DIR> ..
06/03/2008 12:09 PM <DIR> classes
06/03/2008 12:10 PM <DIR> dojo
06/03/2008 12:10 PM 10,912 org.apache.sling.extensions.dojo-1.1.0.00
1-incubator-SNAPSHOT-sources.jar
06/03/2008 12:10 PM 18,382 org.apache.sling.extensions.dojo-1.1.0.00
1-incubator-SNAPSHOT.jar
2 File(s) 29,294 bytes
*shrug*
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-500) The Dojo Toolkit bundle doesn't include
the Dojo source files
Posted by "Robert Tucker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Tucker closed SLING-500.
-------------------------------
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-500-verify-download.patch, sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601917#action_12601917 ]
Bertrand Delacretaz commented on SLING-500:
-------------------------------------------
Congratulations on issue #500 ;-)
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Craig L. Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602005#action_12602005 ]
Craig L. Ching commented on SLING-500:
--------------------------------------
Just for reference, I'm on Windows Vista and this is what I see after a mvn clean install in the extensions/dojo directory:
C:\dev\sling\trunk\extensions\dojo>mvn --version
Maven version: 2.0.9
Java version: 1.6.0_03
OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"
Directory of C:\dev\sling\trunk\extensions\dojo\target\dojo
06/03/2008 12:49 PM <DIR> .
06/03/2008 12:49 PM <DIR> ..
06/03/2008 12:49 PM <DIR> dojo-release-1.1.0-src
0 File(s) 0 bytes
Directory of C:\dev\sling\trunk\extensions\dojo\target
06/03/2008 12:49 PM <DIR> .
06/03/2008 12:49 PM <DIR> ..
06/03/2008 12:49 PM <DIR> classes
06/03/2008 12:49 PM <DIR> dojo
06/03/2008 12:49 PM 11,079 org.apache.sling.extensions.dojo-1.1.0.001-incubator-SNAPSHOT-sources.jar
06/03/2008 12:49 PM 16,930,736 org.apache.sling.extensions.dojo-1.1.0.001-incubator-SNAPSHOT.jar
2 File(s) 16,941,815 bytes
4 Dir(s) 107,142,922,240 bytes free
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602194#action_12602194 ]
Felix Meschberger commented on SLING-500:
-----------------------------------------
> Question on process: Should I close this now or leave open in case someone wants to apply Lars' patch?
I will apply Lars' patch 'cause it makes sense, I will then resolve the issue and will kindly ask you to close if you are satisifed.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Assignee: Felix Meschberger
> Priority: Minor
> Attachments: SLING-500-verify-download.patch, sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-500) The Dojo Toolkit bundle doesn't
include the Dojo source files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601867#action_12601867 ]
Felix Meschberger commented on SLING-500:
-----------------------------------------
Thanks for reporting this issue.
Your patch replaces the use of the src package by the usual release package of the dojo toolkit. Because we changed this only recently in Rev. 654821 as per SLING-429 to enable running dojo on the server side, I am reluctant to go back without any feedback from Lars Trieloff.
Regardless of the above, the dojo toolkit sources are part of the bundle. So I wonder, why you think, they are not ? Thanks for any clarification.
> The Dojo Toolkit bundle doesn't include the Dojo source files
> -------------------------------------------------------------
>
> Key: SLING-500
> URL: https://issues.apache.org/jira/browse/SLING-500
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 2.0.0
> Reporter: Robert Tucker
> Priority: Minor
> Attachments: sling-500.patch
>
>
> The Dojo Toolkit bundle doesn't actually include the Dojo source files in the jar file created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.