You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/06 06:40:17 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9571: KAFKA-10691: AlterIsr Respond with wrong Error Id

chia7712 commented on a change in pull request #9571:
URL: https://github.com/apache/kafka/pull/9571#discussion_r518550582



##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -2261,7 +2261,7 @@ class KafkaController(val config: KafkaConfig,
     val brokerEpochOpt = controllerContext.liveBrokerIdAndEpochs.get(brokerId)
     if (brokerEpochOpt.isEmpty) {
       info(s"Ignoring AlterIsr due to unknown broker $brokerId")
-      callback.apply(Right(Errors.STALE_BROKER_EPOCH))
+      callback.apply(Right(Errors.UNKNOWN_MEMBER_ID))

Review comment:
       not sure whether ```UNKNOWN_MEMBER_ID`` is more suitable than ```STALE_BROKER_EPOCH```.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org