You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2019/05/30 06:32:37 UTC
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13465
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
This commit disallows explicitly setting the Kudu table id property for
Kudu tables in a ALTER TABLE set statement. The Kudu table id property
is generated when the table is created and should not be altered
afterwards.
This commit also extracts Kudu-related analyzing tests for table alteration,
so that they can be run with or without Kudu/HMS integration enabled.
Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
3 files changed, 132 insertions(+), 122 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13465/1
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 19:11:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Jun 2019 00:09:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 19:49:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@118
PS2, Line 118: // Checking for 'EXTERNAL' is case-insensitive, see IMPALA-5637.
: String keyForExternalProperty =
: MetaStoreUtil.findTblPropKeyCaseInsensitive(tblProperties_, "EXTERNAL");
> nit: while you are here, maybe move this under the 'if (authzConfig.isEnabl
Done
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@132
PS2, Line 132: manually
> nit: what does 'manually' means in this context? Is it possible to set it
Done
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@132
PS2, Line 132:
> nit: drop the extra space or drop the space and the period altogether.
Done
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 18:19:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 12:50:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4406/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 19:49:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Grant Henke, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13465
to look at the new patch set (#3).
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
This commit disallows explicitly setting the Kudu table id property for
Kudu tables in a ALTER TABLE set statement. The Kudu table id property
is generated when the table is created and should not be altered
afterwards.
This commit also extracts Kudu-related analyzing tests for table alteration,
so that they can be run with or without Kudu/HMS integration enabled.
Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
3 files changed, 135 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/13465/3
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3505/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 18:38:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4395/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 22:37:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 20:17:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 03:52:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
This commit disallows explicitly setting the Kudu table id property for
Kudu tables in a ALTER TABLE set statement. The Kudu table id property
is generated when the table is created and should not be altered
afterwards.
This commit also extracts Kudu-related analyzing tests for table alteration,
so that they can be run with or without Kudu/HMS integration enabled.
Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Reviewed-on: http://gerrit.cloudera.org:8080/13465
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Thomas Marshall <tm...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
3 files changed, 135 insertions(+), 126 deletions(-)
Approvals:
Grant Henke: Looks good to me, but someone else must approve
Thomas Marshall: Looks good to me, approved
Alexey Serbin: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4405/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 18:20:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@118
PS2, Line 118: // Checking for 'EXTERNAL' is case-insensitive, see IMPALA-5637.
: String keyForExternalProperty =
: MetaStoreUtil.findTblPropKeyCaseInsensitive(tblProperties_, "EXTERNAL");
nit: while you are here, maybe move this under the 'if (authzConfig.isEnabled())' clause?
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@132
PS2, Line 132: manually
nit: what does 'manually' means in this context? Is it possible to set it 'programmatically'? I would rather drop this 'manually' to avoid ambiguity. Maybe, replace the sentence:
"property '%s' cannot be altered for Kudu tables"
http://gerrit.cloudera.org:8080/#/c/13465/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@132
PS2, Line 132:
nit: drop the extra space or drop the space and the period altogether.
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 16:44:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 )
Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3436/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13465
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1f3f87054db5e28f72a5b54ea5b3c040c1bf22
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 May 2019 07:17:55 +0000
Gerrit-HasComments: No