You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/01 12:54:24 UTC
[GitHub] [kyuubi] xuefeimiaoao opened a new issue, #4058: [TEST] Fix the missing of connectionConf in `SparkQueryTests`
xuefeimiaoao opened a new issue, #4058:
URL: https://github.com/apache/kyuubi/issues/4058
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What kind of test improve?
- [ ] Fix flaky tests.
- [X] Fix bug in tests.
- [ ] Increase test coverage.
- [ ] Other kinds of test improve.
### Describe the issues of the existing tests or improvements for new tests
When execute test `KyuubiOnKubernetesWithClientSparkTestsSuite` with `execute statement - select with variable substitution`, the initial method `org.apache.kyuubi.operation.HiveJDBCTestHelper#withThriftClient` will overlook the connectionConf in `org.apache.kyuubi.operation.JDBCTestHelper#jdbcUrl` :
` def withThriftClient[T](user: Option[String] = None)(f: TCLIService.Iface => T): T = {`
` TClientTestUtils.withThriftClient(`
` jdbcUrl.stripPrefix(URL_PREFIX).split("/;").head,`
` user)(f)`
` }`
Here we just abort the tail of `jdbcUrl.stripPrefix(URL_PREFIX).split("/;")`, in which the connectionConfs are set.
In that case the `org.apache.kyuubi.kubernetes.test.deployment.KyuubiOnKubernetesWithClientSparkTestsSuite#connectionConf` was invalid actually.
### Are you willing to submit PR?
- [X] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
- [ ] No. I cannot submit a PR at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed issue #4058: [TEST] Fix the missing of connectionConf in `SparkQueryTests`
Posted by GitBox <gi...@apache.org>.
pan3793 closed issue #4058: [TEST] Fix the missing of connectionConf in `SparkQueryTests`
URL: https://github.com/apache/kyuubi/issues/4058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org