You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Mladen Turk <mt...@apache.org> on 2010/02/21 08:56:06 UTC

[VOTE] Release Commons Daemon 1.0.2 based on RC1

After a long time and many bug fixes we have new
Commons Daemon release candidate.

RC1 Release is here:
http://people.apache.org/~mturk/daemon/
Tag is here:
https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/

---------------
[ ] +1  I support this release
[ ] +0
[ ] -0
[ ] -1  I oppose this release because...
----------------

Vote will close after 72 hours.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Bill Barker <bi...@verizon.net>.

--------------------------------------------------
From: "Mladen Turk" <mt...@apache.org>
Sent: Saturday, February 20, 2010 11:56 PM
To: "Commons Developers List" <de...@commons.apache.org>
Subject: [VOTE] Release Commons Daemon 1.0.2 based on RC1

> After a long time and many bug fixes we have new
> Commons Daemon release candidate.
>
> RC1 Release is here:
> http://people.apache.org/~mturk/daemon/
> Tag is here:
> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
>
> ---------------
> [X] +1  I support this release (non-binding)
> [ ] +0
> [ ] -0
> [ ] -1  I oppose this release because...
> ----------------
>
> Vote will close after 72 hours.
>
>
> Regards
> -- 
> ^TM
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Niall Pemberton <ni...@gmail.com>.
+!

Niall

On Sun, Feb 21, 2010 at 7:56 AM, Mladen Turk <mt...@apache.org> wrote:
> After a long time and many bug fixes we have new
> Commons Daemon release candidate.
>
> RC1 Release is here:
> http://people.apache.org/~mturk/daemon/
> Tag is here:
> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
>
> ---------------
> [ ] +1  I support this release
> [ ] +0
> [ ] -0
> [ ] -1  I oppose this release because...
> ----------------
>
> Vote will close after 72 hours.
>
>
> Regards
> --
> ^TM
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, Feb 22, 2010 at 7:45 AM, Mladen Turk <mt...@apache.org> wrote:
> On 02/22/2010 03:40 AM, sebb wrote:
>>
>> On 21/02/2010, Mladen Turk<mt...@apache.org>  wrote:
>>
>> There are several files without AL headers, for example:
>> build.properties.sample
>> src/docs/daemon.css
>>
>
> This file is there without ASL header forever
> Several releases has been made with this file
> having no ASL header.
> I don't see how this can be release blocker.
> I'm not even sure it is required that each file
> has a license header (but that's another topic)

The "ASF Source Header and Copyright Notice Policy" here:
    http://www.apache.org/legal/src-headers.html

says:

"2. Each source file should include the following license header..."

and then later under the FAQ it clarifies this with:

"What files in an Apache release do not require a license header?"

"A file without any degree of creativity in either its literal
elements or its structure is not protected by copyright law;
therefore, such a file does not require a license header. If in doubt
about the extent of the file's creativity, add the license header to
the file"

Niall

>> There are two scripts which appear to be GNU licensed:
>>
>> src/native/unix/support/config.guess
>> src/native/unix/support/config.sub
>>
>
> Bill already explained why.
> Almost every native ASF project have them.
>
>>
>> Minor points:
>>
>> README.txt refers to http://jakarta.apache.org/commons/ (and could do
>> with some editting to improve the grammar)
>>
>
> This kind of things is for JIRA.
>
>
> Regards
> --
> ^TM
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Mladen Turk <mt...@apache.org>.
On 02/22/2010 03:40 AM, sebb wrote:
> On 21/02/2010, Mladen Turk<mt...@apache.org>  wrote:
>
> There are several files without AL headers, for example:
> build.properties.sample
> src/docs/daemon.css
>

This file is there without ASL header forever
Several releases has been made with this file
having no ASL header.
I don't see how this can be release blocker.
I'm not even sure it is required that each file
has a license header (but that's another topic)


> There are two scripts which appear to be GNU licensed:
>
> src/native/unix/support/config.guess
> src/native/unix/support/config.sub
>

Bill already explained why.
Almost every native ASF project have them.

>
> Minor points:
>
> README.txt refers to http://jakarta.apache.org/commons/ (and could do
> with some editting to improve the grammar)
>

This kind of things is for JIRA.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Bill Barker <bi...@verizon.net>.

--------------------------------------------------
From: "sebb" <se...@gmail.com>
Sent: Sunday, February 21, 2010 6:40 PM
To: "Commons Developers List" <de...@commons.apache.org>
Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

> On 21/02/2010, Mladen Turk <mt...@apache.org> wrote:
>> After a long time and many bug fixes we have new
>>  Commons Daemon release candidate.
>>
>>  RC1 Release is here:
>>  http://people.apache.org/~mturk/daemon/
>>  Tag is here:
>> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
>>
>>  ---------------
>>  [ ] +1  I support this release
>>  [ ] +0
>>  [ ] -0
>>  [ ] -1  I oppose this release because...
>>  ----------------
>>
>>  Vote will close after 72 hours.
>
> -1
>
> There are several files without AL headers, for example:
> build.properties.sample
> src/docs/daemon.css
>
> There are two scripts which appear to be GNU licensed:
>
> src/native/unix/support/config.guess
> src/native/unix/support/config.sub
>
> Is this permitted? If so where is this documented?
>

<license-quote>
# As a special exception to the GNU General Public License, if you
# distribute this file as part of a program that contains a
# configuration script generated by Autoconf, you may include it under
# the same distribution terms that you use for the rest of that program.
</license-quote>

The commons-daemon configure script is generated by Autoconf, and so falls 
under this exception.

> Minor points:
>
> README.txt refers to http://jakarta.apache.org/commons/ (and could do
> with some editting to improve the grammar)
>
>
>>
>>  Regards
>>  --
>>  ^TM
>>
>> ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by sebb <se...@gmail.com>.
On 21/02/2010, Mladen Turk <mt...@apache.org> wrote:
> After a long time and many bug fixes we have new
>  Commons Daemon release candidate.
>
>  RC1 Release is here:
>  http://people.apache.org/~mturk/daemon/
>  Tag is here:
> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
>
>  ---------------
>  [ ] +1  I support this release
>  [ ] +0
>  [ ] -0
>  [ ] -1  I oppose this release because...
>  ----------------
>
>  Vote will close after 72 hours.

-1

There are several files without AL headers, for example:
build.properties.sample
src/docs/daemon.css

There are two scripts which appear to be GNU licensed:

src/native/unix/support/config.guess
src/native/unix/support/config.sub

Is this permitted? If so where is this documented?

Minor points:

README.txt refers to http://jakarta.apache.org/commons/ (and could do
with some editting to improve the grammar)


>
>  Regards
>  --
>  ^TM
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by sebb <se...@gmail.com>.
On 23/02/2010, Bill Barker <bi...@verizon.net> wrote:
>
>
>  --------------------------------------------------
>  From: "Phil Steitz" <ph...@gmail.com>
>  Sent: Monday, February 22, 2010 5:58 PM
>  To: "Commons Developers List" <de...@commons.apache.org>
>  Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1
>
>
> > Mladen Turk wrote:
> >
> > > After a long time and many bug fixes we have new
> > > Commons Daemon release candidate.
> > >
> > > RC1 Release is here:
> > > http://people.apache.org/~mturk/daemon/
> > > Tag is here:
> > >
> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
> > >
> > >
> > > ---------------
> > > [ ] +1  I support this release
> > > [ ] +0
> > > [ ] -0
> > > [ ] -1  I oppose this release because...
> > > ----------------
> > >
> > > Vote will close after 72 hours.
> > >
> > >
> > > Regards
> > >
> >
> > -1
> >
> > Per Sebb's and Niall's comments, license headers are required.
> >
> >
>
>  I've added the license headers to those two files. Will look for any
> others.
>
>
> > The release notes also need to include a complete list of bug fixes
> > since 1.0.2.  The link to the project JIRA is not good enough for
> > this, as there is no report there detailing the bugs fixed in 1.0.2
> > and the fix versions on resolved issues are generally missing in
> > JIRA, so there is no way to get this info from JIRA directly.  Is
> > there are changelog or status page anywhere that we can use to build
> > a list of 1.0.2 resolved issues from?
> >
> >
>
>  I've added the list from Jira of bug fixes.  The jsvc part has a detailed
> CHANGES.txt that seems to be up to date.  The procrun part could use one
> (except that it has mostly been distributed from Tomcat for years, so it may
> be in the Tomcat change log).  Except for sebb's Thread safety change (and
> both jsvc and procrun access this on a single Thread), the Java portion is
> largely unchanged since the project came to live in commons.

The thread-safety change I made was to a Test file, so does not need
to be documented.

>
>
> > Phil
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Mladen Turk <mt...@apache.org>.
On 02/23/2010 06:23 AM, Bill Barker wrote:
>
> Ok, I think I've gotten them all. The remaining files are mostly MSVC
> build files, which are machine-generated, so can't be copywrited. Since
> this vote is about to expire in failure, we should be set to try RC2 if
> Mladen is still up to it.
>

I'll do RC2 today, although all those changes are cosmetic.
Good thing is that I can reuse the native binaries from RC1 so
that will require order of magnitude less work then with RC1.

Thanks everyone who stepped in.
I suppose I won't have to wait another 72 hours for RC2 vote :)

Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Bill Barker <bi...@verizon.net>.

--------------------------------------------------
From: "Bill Barker" <bi...@verizon.net>
Sent: Monday, February 22, 2010 7:51 PM
To: "Commons Developers List" <de...@commons.apache.org>
Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

>
>
> --------------------------------------------------
> From: "Phil Steitz" <ph...@gmail.com>
> Sent: Monday, February 22, 2010 5:58 PM
> To: "Commons Developers List" <de...@commons.apache.org>
> Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1
>
>> Mladen Turk wrote:
>>> After a long time and many bug fixes we have new
>>> Commons Daemon release candidate.
>>>
>>> RC1 Release is here:
>>> http://people.apache.org/~mturk/daemon/
>>> Tag is here:
>>> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
>>>
>>>
>>> ---------------
>>> [ ] +1  I support this release
>>> [ ] +0
>>> [ ] -0
>>> [ ] -1  I oppose this release because...
>>> ----------------
>>>
>>> Vote will close after 72 hours.
>>>
>>>
>>> Regards
>>
>> -1
>>
>> Per Sebb's and Niall's comments, license headers are required.
>>
>
> I've added the license headers to those two files. Will look for any 
> others.
>

Ok, I think I've gotten them all.  The remaining files are mostly MSVC build 
files, which are machine-generated, so can't be copywrited.  Since this vote 
is about to expire in failure, we should be set to try RC2 if Mladen is 
still up to it.

>> The release notes also need to include a complete list of bug fixes
>> since 1.0.2.  The link to the project JIRA is not good enough for
>> this, as there is no report there detailing the bugs fixed in 1.0.2
>> and the fix versions on resolved issues are generally missing in
>> JIRA, so there is no way to get this info from JIRA directly.  Is
>> there are changelog or status page anywhere that we can use to build
>> a list of 1.0.2 resolved issues from?
>>
>
> I've added the list from Jira of bug fixes.  The jsvc part has a detailed 
> CHANGES.txt that seems to be up to date.  The procrun part could use one 
> (except that it has mostly been distributed from Tomcat for years, so it 
> may be in the Tomcat change log).  Except for sebb's Thread safety change 
> (and both jsvc and procrun access this on a single Thread), the Java 
> portion is largely unchanged since the project came to live in commons.
>
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Bill Barker <bi...@verizon.net>.

--------------------------------------------------
From: "Phil Steitz" <ph...@gmail.com>
Sent: Monday, February 22, 2010 5:58 PM
To: "Commons Developers List" <de...@commons.apache.org>
Subject: Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

> Mladen Turk wrote:
>> After a long time and many bug fixes we have new
>> Commons Daemon release candidate.
>>
>> RC1 Release is here:
>> http://people.apache.org/~mturk/daemon/
>> Tag is here:
>> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
>>
>>
>> ---------------
>> [ ] +1  I support this release
>> [ ] +0
>> [ ] -0
>> [ ] -1  I oppose this release because...
>> ----------------
>>
>> Vote will close after 72 hours.
>>
>>
>> Regards
>
> -1
>
> Per Sebb's and Niall's comments, license headers are required.
>

I've added the license headers to those two files. Will look for any others.

> The release notes also need to include a complete list of bug fixes
> since 1.0.2.  The link to the project JIRA is not good enough for
> this, as there is no report there detailing the bugs fixed in 1.0.2
> and the fix versions on resolved issues are generally missing in
> JIRA, so there is no way to get this info from JIRA directly.  Is
> there are changelog or status page anywhere that we can use to build
> a list of 1.0.2 resolved issues from?
>

I've added the list from Jira of bug fixes.  The jsvc part has a detailed 
CHANGES.txt that seems to be up to date.  The procrun part could use one 
(except that it has mostly been distributed from Tomcat for years, so it may 
be in the Tomcat change log).  Except for sebb's Thread safety change (and 
both jsvc and procrun access this on a single Thread), the Java portion is 
largely unchanged since the project came to live in commons.

> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Commons Daemon 1.0.2 based on RC1

Posted by Phil Steitz <ph...@gmail.com>.
Mladen Turk wrote:
> After a long time and many bug fixes we have new
> Commons Daemon release candidate.
> 
> RC1 Release is here:
> http://people.apache.org/~mturk/daemon/
> Tag is here:
> https://svn.apache.org/viewvc/commons/proper/daemon/tags/COMMONS_DAEMON_1_0_2_RC1/
> 
> 
> ---------------
> [ ] +1  I support this release
> [ ] +0
> [ ] -0
> [ ] -1  I oppose this release because...
> ----------------
> 
> Vote will close after 72 hours.
> 
> 
> Regards

-1

Per Sebb's and Niall's comments, license headers are required.

The release notes also need to include a complete list of bug fixes
since 1.0.2.  The link to the project JIRA is not good enough for
this, as there is no report there detailing the bugs fixed in 1.0.2
and the fix versions on resolved issues are generally missing in
JIRA, so there is no way to get this info from JIRA directly.  Is
there are changelog or status page anywhere that we can use to build
a list of 1.0.2 resolved issues from?

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org