You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/06/22 19:15:00 UTC

[jira] [Commented] (GEODE-10082) Duplicate values found in DSCode enums

    [ https://issues.apache.org/jira/browse/GEODE-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557638#comment-17557638 ] 

ASF subversion and git services commented on GEODE-10082:
---------------------------------------------------------

Commit 52aa245d88420a192846dd9edc38a5b7af2d4a93 in geode-native's branch refs/heads/master from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=52aa245d8 ]

GEODE-10082: Fixes mixing of DSCode and DSFid enums. (#933)

Moves InterestResultPolicy and ClientProxyMembershipId to DSFid.

Replaces eroneous CacheableEnum with PDX_ENUM.

> Duplicate values found in DSCode enums
> --------------------------------------
>
>                 Key: GEODE-10082
>                 URL: https://issues.apache.org/jira/browse/GEODE-10082
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Blake Bender
>            Assignee: Jacob Barrett
>            Priority: Major
>              Labels: needsTriage, pull-request-available
>             Fix For: 1.15.0
>
>
> The following snippet appears in DSCode.hpp:
> ``` 
>   CacheableEnum = 94,
>   ClientProxyMembershipId = 38,
>   CacheableUserData = 39,
>   CacheableUserData2 = 38,
>   CacheableUserData4 = 37,
>   PDX = 93,
>   PDX_ENUM = 94,
>   InterestResultPolicy = 37,
> };
> ```
> `CacheableEnum` is the name of the class that geode-native uses for `PDX_ENUM`, it should not exist as an enum value.  `ClientProxyMembershipId`, `InternalDistributedMember`, and `InterestResultPolicy` are `DataSerializableFixedId` values, and belong in that enum rather than DSCode.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)