[GitHub] [superset] CarpathianUA commented on a change in pull request #18668: feat: pin version of superset in helm chart

[GitBox <gi...@apache.org>]

CarpathianUA commented on a change in pull request #18668:
URL: https://github.com/apache/superset/pull/18668#discussion_r804899195



##########
File path: helm/superset/values.yaml
##########
@@ -160,7 +160,7 @@ extraConfigMountPath: "/app/configs"
 
 image:
   repository: apache/superset
-  tag: latest
+  # tag: "v{{ $.Chart.AppVersion }}"

Review comment:
       BTW, I'm not sure that the referencing  `"v{{ $.Chart.AppVersion }}"` will work at all, since Helm values don't support any templating besides `include` and `template` via plane YAML AFAIR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org