You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:39:03 UTC

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5390: server: fix reset sshkey is broken in master/4.16

weizhouapache commented on a change in pull request #5390:
URL: https://github.com/apache/cloudstack/pull/5390#discussion_r699273501



##########
File path: server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
##########
@@ -254,10 +254,6 @@ public boolean saveSSHKey(final Network network, final NicProfile nic, final Vir
 
         final boolean canHandle = canHandle(network.getTrafficType());
 
-        if (canHandle) {

Review comment:
       since password is not reset when reset sshkey (in #4819 ), it is not needed to save password in vm details.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org