You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/07/28 00:51:14 UTC
[I] Remove the resolved Known Gap about organization-adapter file validation [magpie]
justinmclean opened a new issue, #975:
URL: https://github.com/apache/magpie/issues/975
## Summary
`tools/spec-loop/specs/organization-adapters.md` lists a Known Gap saying no validator check
enforces the required files in `organizations/<org>/`. That check was built and merged in July
2026. Remove the stale bullet and describe the check that exists.
## Background
The specs under `tools/spec-loop/specs/` are the framework's source of truth, and `AGENTS.md`
is explicit that they must not fall behind the code. This bullet says a validator check does not
exist:
> No structural validator check yet enforces required files in `organizations/<org>/`
> (currently README + organization.md by convention).
`validate_organization_structure` has enforced exactly that since PR #721: every
`organizations/<org>/` directory except `_template` must contain `README.md` and
`organization.md`, as a HARD violation. The PR that added it said in its commit message that it
cleared this gap, but the spec edit never happened.
A stale Known Gap is worse than no Known Gap: someone planning work reads it as an open task and
may build the check a second time.
## Where to look
- `tools/spec-loop/specs/organization-adapters.md` line 125 — the Known Gap bullet to remove.
- `tools/skill-and-tool-validator/src/skill_and_tool_validator/__init__.py` — search for
`validate_organization_structure` to see what the check actually does, including the
`_template` exclusion.
- Other spec files in the same directory show how shipped behaviour is normally described (look
at how another spec's body names the tool that implements it).
## Acceptance criteria
- [ ] The Known Gap bullet about validator enforcement is gone from
`organization-adapters.md`.
- [ ] The spec body says somewhere that `README.md` and `organization.md` are enforced, and
names `validate_organization_structure` as what enforces them.
- [ ] No other Known Gap in the file is removed.
- [ ] `prek run --all-files` passes.
## Estimated effort
~30 minutes for someone new to the codebase; most of it is reading the validator function to
describe it accurately.
## Getting started
[[How to contribute](https://github.com/apache/airflow-steward/blob/main/CONTRIBUTING.md#your-first-contribution)](https://github.com/apache/airflow-steward/blob/main/CONTRIBUTING.md#your-first-contribution)
This issue was drafted with the help of an AI-assisted tool and reviewed by a Magpie maintainer before posting. If anything here is unclear or looks wrong, say so on the issue: a real person is reading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the resolved Known Gap about organization-adapter file validation [magpie]
Posted by "CogentCoder73 (via GitHub)" <gi...@apache.org>.
CogentCoder73 commented on issue #975:
URL: https://github.com/apache/magpie/issues/975#issuecomment-5100101616
Great, I'll grab this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the resolved Known Gap about organization-adapter file validation [magpie]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #975:
URL: https://github.com/apache/magpie/issues/975#issuecomment-5100364815
Thanks for asking to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the resolved Known Gap about organization-adapter file validation [magpie]
Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean closed issue #975: Remove the resolved Known Gap about organization-adapter file validation
URL: https://github.com/apache/magpie/issues/975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org