You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/25 15:24:16 UTC

[GitHub] [activemq-artemis] AntonRoskvist opened a new pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

AntonRoskvist opened a new pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519


   ...in schema file so it matches documentation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807449459


   LGTM tbh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807244505


   I would suggest rather than changing the order which will break existing installs the docs are simply updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] michaelandrepearce edited a comment on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807244505


   I would suggest rather than changing the order which will break existing installs the docs are simply updated. That is if this feature already released...if it hasnt this comment can be disregarded


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807382278


   @clebertsuconic there is no issue if it hasnt been released yet. As i said, disregard my comment if it hasn't.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807412057


   I even thought this was the original PR. So disregard anything I said also.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] AntonRoskvist commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
AntonRoskvist commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807300849


   It is not released yet, just sent that PR a few days back 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807306613


   This has not been released yet.  What is the issue ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic merged pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3519: ARTEMIS-3198 - Fix order of concurrency parameter...

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3519:
URL: https://github.com/apache/activemq-artemis/pull/3519#issuecomment-807411523


   I'm completely lost on what was the issue Michael. I'm on the iPhone. I will review this later :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org