You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/02 17:32:21 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #16917: refactor: sql lab command: separate concerns into different modules
codecov[bot] edited a comment on pull request #16917:
URL: https://github.com/apache/superset/pull/16917#issuecomment-932788706
# [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16917](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcf24fb) into [master](https://codecov.io/gh/apache/superset/commit/77e7d162d2e4fd0f570276e896ee81c6584a8d2b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77e7d16) will **decrease** coverage by `0.21%`.
> The diff coverage is `82.70%`.
> :exclamation: Current head dcf24fb differs from pull request most recent head 98ca456. Consider uploading reports for the commit 98ca456 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16917/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16917 +/- ##
==========================================
- Coverage 77.03% 76.82% -0.22%
==========================================
Files 1021 1026 +5
Lines 54846 55005 +159
Branches 7481 7481
==========================================
+ Hits 42250 42256 +6
- Misses 12349 12502 +153
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `81.83% <82.44%> (-0.02%)` | :arrow_down: |
| postgres | `81.90% <82.70%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `81.98% <82.70%> (-0.44%)` | :arrow_down: |
| sqlite | `81.51% <82.44%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/dao.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `88.63% <ø> (ø)` | |
| [superset/sqllab/sqllab\_execution\_context.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbGxhYl9leGVjdXRpb25fY29udGV4dC5weQ==) | `90.55% <ø> (ø)` | |
| [superset/sqllab/sql\_json\_executer.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3NxbF9qc29uX2V4ZWN1dGVyLnB5) | `74.39% <74.39%> (ø)` | |
| [superset/sqllab/exceptions.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4Y2VwdGlvbnMucHk=) | `67.39% <75.00%> (-13.57%)` | :arrow_down: |
| [superset/sqllab/command.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2NvbW1hbmQucHk=) | `85.21% <77.08%> (+2.22%)` | :arrow_up: |
| [superset/sqllab/execution\_context\_convertor.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2V4ZWN1dGlvbl9jb250ZXh0X2NvbnZlcnRvci5weQ==) | `86.95% <86.95%> (ø)` | |
| [superset/sqllab/query\_render.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3F1ZXJ5X3JlbmRlci5weQ==) | `88.46% <88.46%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `95.12% <88.88%> (-1.76%)` | :arrow_down: |
| [superset/sqllab/validators.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL3ZhbGlkYXRvcnMucHk=) | `88.88% <88.88%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.85% <96.42%> (+0.37%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/16917/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [77e7d16...98ca456](https://codecov.io/gh/apache/superset/pull/16917?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org