[GitHub] [superset] jfrag1 commented on a diff in pull request #25081: fix: Allow embedded guest user datasource access with dashboard context

["jfrag1 (via GitHub)" <gi...@apache.org>]

jfrag1 commented on code in PR #25081:
URL: https://github.com/apache/superset/pull/25081#discussion_r1305190344


##########
tests/integration_tests/security/guest_token_security_tests.py:
##########
@@ -91,14 +100,14 @@ def test_get_guest_user_roles_implicit(self):
         self.assertEqual(guest.roles, roles)
 
 
-@mock.patch.dict(
+@patch.dict(
     "superset.extensions.feature_flag_manager._feature_flags",
     EMBEDDED_SUPERSET=True,
 )
-@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+@pytest.mark.usefixtures("load_birth_names_dashboard_with_slices_class_scope")

Review Comment:
   This change speeds these tests up significantly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org