[GitHub] [drill] arina-ielchiieva edited a comment on issue #1845: DRILL-7353: Wrong driver class is written to the java.sql.Driver

[GitBox <gi...@apache.org>]

arina-ielchiieva edited a comment on issue #1845: DRILL-7353: Wrong driver class is written to the java.sql.Driver
URL: https://github.com/apache/drill/pull/1845#issuecomment-522968730
 
 
   @agozhiy could you provide more context to this issue. Why this approach was chosen?
   Why calcite `java.sql.Driver` is chosen over Drill's one? What if other `java.sql.Driver` will be present in other lib? Which one will be chosen? From the first glance, current approach looks brittle, taking into account that some other file might be chosen over Drill's one. Is there a way to merge all `java.sql.Driver` into one or excluding all unnecessary? Since there are no unit tests to ensure the proper `java.sql.Driver` is chosen, we need to make sure such issue won't pop again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services