[jira] [Updated] (HBASE-9964) start-hbase.sh returns success exit status and emits "starting master" message when master failed to start

["Ashish Singhi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Singhi updated HBASE-9964:
---------------------------------

    Attachment: HBASE-9964.patch

I faced the same issue when I configured non advisable value *0.9* to *hbase.regionserver.global.memstore.size* and then executed hbase-daemon.sh start master. 
Master process startup failed with a RuntimeException logged in the log file but the script exit code was zero, which I felt is not correct.

Attaching a simple patch for this issue. The fix I have done is after start command is sent to the main class we will sleep for 3 seconds and check whether the background process is still running if it is not running then exit the script with non zero exit code.
Generally if any configuration is miss configured then java process may terminate with in 3 seconds.

> start-hbase.sh returns success exit status and emits "starting master" message when master failed to start
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9964
>                 URL: https://issues.apache.org/jira/browse/HBASE-9964
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.13
>         Environment: Linux x86_64 (Centos 6.4)
>            Reporter: Jason Vas Dias
>         Attachments: HBASE-9964.patch
>
>
> The bin/start-hbase.sh script returns an exit status indicating success, and emits the message : 'starting master, logging to ...' ,  even though the master failed to start:
>     $ ./bin/start-hbase.sh
>     starting master, logging to /home/jason/3P/hbase-0.94.13/logs/hbase-jason-master-jvds.out
>     $ echo $?
>     0
> #  ^- this indicates successful exit status on Linux / UNIX-like systems
>     $ egrep 'start master|RuntimeException' logs/hbase-jason-master-jvds.log 
> 2013-11-13 14:15:28,309 ERROR org.apache.hadoop.hbase.master.HMasterCommandLine: Failed to start master
> java.lang.RuntimeException: Failed suppression of fs shutdown hook: Thread[Thread-27,5,main]
> The start-base.sh script should IMHO in the above scenario emit a message like 
> 'Failed to start the hbase master:   java.lang.RuntimeException: Failed suppression of fs shutdown hook'
> and return a non-zero exit status.



--
This message was sent by Atlassian JIRA
(v6.2#6252)